[circuits] Use swap_bytes for SHA-256 & SHA-512 digest BE to LE

[jimpo]

No description provided.

[jimpo]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• [circuits] Use swap_bytes for SHA-256 & SHA-512 digest BE to LE #902 👈 (View in Graphite)
• [circuits] swap_bytes_32 for reversing bytes in 32-bit words #901
• [circuits] swap_bytes circuit gadget builder #900
• main

---

How to use the Graphite Merge Queue

Add the label merge-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[benediamond]

this looks obviously extremely good; my only quick question: i wonder why only the zklogin snapshot changed, and not the sha256 snapshot?

[jimpo]

Those examples provide the inputs and outputs already in big-endian order (by calling convention). The zklogin example needs to swap endianness for its other checks.

[benediamond]

cool, approved.

people in slack have talked about similar problems: see e.g.. @onesk, i wonder if you can use these too....

[graphite-app]

Merge activity

• Sep 1, 8:49 PM UTC: jimpo added this pull request to the Graphite merge queue.
• Sep 1, 8:53 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #901.
• Sep 1, 8:53 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #901.
• Sep 1, 9:57 PM UTC: jimpo added this pull request to the Graphite merge queue.
• Sep 1, 9:57 PM UTC: CI is running for this pull request on a draft pull request (#905) due to your merge queue CI optimization settings.
• Sep 1, 10:04 PM UTC: Merged by the Graphite merge queue via draft PR: #905.