Skip to content

Release/4.2 python ctor wrapper stereo#2086

Closed
zygfrydw wants to merge 1 commit intoborglab:release/4.2from
zygfrydw:release/4.2-python-ctor-wrapper-stereo
Closed

Release/4.2 python ctor wrapper stereo#2086
zygfrydw wants to merge 1 commit intoborglab:release/4.2from
zygfrydw:release/4.2-python-ctor-wrapper-stereo

Conversation

@zygfrydw
Copy link
Copy Markdown

@zygfrydw zygfrydw commented Apr 10, 2025

This MR exposes body_P_sensor parameter in Python wrapper for GenericStereoFactor3D.

I am working on a stereo vision application for a robot where the camera frame differs from the body link. I cannot prototype in Python because the body_P_sensor parameter for GenericStereoFactor3D constructor is not exposed.

After the MR:

graph.push_back(GenericStereoFactor3D(
    StereoPoint2(uL, uR, v), noise_model, 1, 3, K, body_to_camera)

@zygfrydw zygfrydw changed the base branch from develop to release/4.2 April 10, 2025 12:41
@zygfrydw zygfrydw force-pushed the release/4.2-python-ctor-wrapper-stereo branch from d57c921 to 3cfbc20 Compare April 10, 2025 12:47
Signed-off-by: Zygfryd Wieszok <zygfryd.wieszok@gmail.com>
@zygfrydw zygfrydw force-pushed the release/4.2-python-ctor-wrapper-stereo branch from 3cfbc20 to 8e199b4 Compare April 10, 2025 13:00
Copy link
Copy Markdown
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! After CI succeeds, let’s merge (whoever gets to it first).

@dellaert
Copy link
Copy Markdown
Member

Oopsies. Build fails on Linux. Something with FindBoost. Ideas anyone?

@zygfrydw
Copy link
Copy Markdown
Author

The "Install Boost" CI step fails due to gzip: stdin: not in gzip format after wget.

@dellaert
Copy link
Copy Markdown
Member

Oh, I see, you’re targeting the release branch. That requires a bit of care, actually. We are gearing up to release 4.3, so could you please target develop? I will close this PR as I think if you’re starting from 4.2 the PR will be problematic. Better to check out develop, patch slam.i, and PR to develop.

@dellaert dellaert closed this Apr 10, 2025
@zygfrydw
Copy link
Copy Markdown
Author

zygfrydw commented Apr 10, 2025

I have investigated the boost problem and the CI failed because the archive used for the CI does not exist any more.
The command wget https://boostorg.jfrog.io/artifactory/main/release/1.67.0/source/boost_1_67_0.tar.gz returns a HTML with an error instead of tar.gz.

I will port this MR to the develop branch for community, but for the project I am working on, we are using GTSAM 4.2. Due to a limited time schedule, I don't think we can switch to 4.3 in the foreseeable future, so we will continue with the fork.

@zygfrydw
Copy link
Copy Markdown
Author

I checked the develop branch, and the changes I propose are already there slam.i.

@zygfrydw zygfrydw deleted the release/4.2-python-ctor-wrapper-stereo branch April 10, 2025 14:17
@zygfrydw zygfrydw restored the release/4.2-python-ctor-wrapper-stereo branch April 10, 2025 14:20
@zygfrydw zygfrydw deleted the release/4.2-python-ctor-wrapper-stereo branch April 10, 2025 14:20
@zygfrydw zygfrydw restored the release/4.2-python-ctor-wrapper-stereo branch April 10, 2025 14:20
@zygfrydw zygfrydw deleted the release/4.2-python-ctor-wrapper-stereo branch April 10, 2025 14:20
@zygfrydw zygfrydw restored the release/4.2-python-ctor-wrapper-stereo branch April 10, 2025 14:21
@dellaert
Copy link
Copy Markdown
Member

That sounds like a plan :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants