Release/4.2 python ctor wrapper stereo#2086
Release/4.2 python ctor wrapper stereo#2086zygfrydw wants to merge 1 commit intoborglab:release/4.2from
Conversation
d57c921 to
3cfbc20
Compare
Signed-off-by: Zygfryd Wieszok <zygfryd.wieszok@gmail.com>
3cfbc20 to
8e199b4
Compare
dellaert
left a comment
There was a problem hiding this comment.
Awesome! After CI succeeds, let’s merge (whoever gets to it first).
|
Oopsies. Build fails on Linux. Something with FindBoost. Ideas anyone? |
|
The "Install Boost" CI step fails due to |
|
Oh, I see, you’re targeting the release branch. That requires a bit of care, actually. We are gearing up to release 4.3, so could you please target develop? I will close this PR as I think if you’re starting from 4.2 the PR will be problematic. Better to check out develop, patch slam.i, and PR to develop. |
|
I have investigated the boost problem and the CI failed because the archive used for the CI does not exist any more. I will port this MR to the |
|
I checked the |
|
That sounds like a plan :-) |
This MR exposes
body_P_sensorparameter in Python wrapper forGenericStereoFactor3D.I am working on a stereo vision application for a robot where the camera frame differs from the body link. I cannot prototype in Python because the
body_P_sensorparameter forGenericStereoFactor3Dconstructor is not exposed.After the MR: