ROS package.xml: do not depend on boost#2171
Conversation
GTSAM could be built now without boost, so let's not propagate the dependency downstream.
|
Serialization is still on boost |
|
We might really start to consider using Cereal for the serialization (optionally). But we probably still want binary compatibility with older serialized files using boost::serialization... |
|
Hmm... but so the current state is, if we try to build w/o Boost: does not build? or builds but it "only" lacks serialization? |
|
It totally builds and works, just there's no serialization |
|
Great! Then, if you all agree with the ROS package of GTSAM not having serialization (with the gain of being lighter), this PR could be merged. Mentioned on ROS discourse here too. |
|
I have no objection to that. |
|
@ProfFan if you agree please merge. So some process on ros build will need to turn them off. |
|
Thanks for the pointer Frank! Yes, we'll probably need to turn that off, via cmake cli flags, no need to touch gtsam upstream. |
GTSAM could be built now without boost, so let's not propagate the dependency downstream.
LMK if I'm wrong, but boost should be completely optional by now, right?
If you could also please merge this into the release 4.3 branch, I will create a new ROS release from that to see how it goes... 🤞