Merged
Conversation
Contributor
|
Hallo Frank, thanks for taking your time. I'll take a closer look as well by the end of this week! |
mkielo3
reviewed
Jul 30, 2025
mkielo3
approved these changes
Jul 30, 2025
Member
Author
|
@LimHyungTae any comments before I merge? After I merge you should in principle be able to abandon your fork and just run VGGT-SLAM after |
Member
Author
|
I'll merge now, so @LimHyungTae can test whether |
Contributor
|
Thanks, @dellaert, everything looks good to me (and the captured figure is VGGT-SLAM with 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SL(4), based on fork by @LimHyungTae, here: https://github.com/MIT-SPARK/gtsam_with_sl4
I made a bunch of changes to leverage LieGroup and MatrixLieGroup, added unit test, and converted the python example to a notebook.