Skip to content

minor: Fix missing dllexport.h#2292

Closed
ProfFan wants to merge 2 commits intodevelopfrom
fan/fix_cephes
Closed

minor: Fix missing dllexport.h#2292
ProfFan wants to merge 2 commits intodevelopfrom
fan/fix_cephes

Conversation

@ProfFan
Copy link
Copy Markdown
Collaborator

@ProfFan ProfFan commented Oct 26, 2025

shell: bash
run: |
git -C ${{ env.VCPKG_INSTALLATION_ROOT }} clean -fdx
git -C ${{ env.VCPKG_INSTALLATION_ROOT }} pull
Copy link
Copy Markdown
Contributor

@talregev talregev Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mean to be on the latest vcpkg. I don't recommended it. Because many time the master is got broken.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not wait for every two weeks update? why you want it up to date?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is broken right now, we can't merge new PRs

Copy link
Copy Markdown
Contributor

@talregev talregev Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a temporary fix that you already merge.
You can rebase this PR to develop branch and undo these changes.

@ProfFan ProfFan closed this Oct 29, 2025
@varunagrawal varunagrawal deleted the fan/fix_cephes branch February 1, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants