Skip to content

minor: Fix missing dllexport.h #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ProfFan wants to merge 2 commits into from
Closed

minor: Fix missing dllexport.h #2292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a466796
Fix missing dllexport.h
ProfFan Oct 26, 2025
a94b5b1
Fix vcpkg
ProfFan Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/vcpkg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,12 @@ jobs:
run: |
VCPKG_BASH_PATH=${VCPKG_INSTALLATION_ROOT//\\//}
echo "VCPKG_INSTALLATION_ROOT=$VCPKG_BASH_PATH" >> "$GITHUB_ENV"

- name: Update vcpkg
shell: bash
run: |
git -C ${{ env.VCPKG_INSTALLATION_ROOT }} clean -fdx
git -C ${{ env.VCPKG_INSTALLATION_ROOT }} pull
Copy link
Copy Markdown
Contributor

@talregev talregev Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mean to be on the latest vcpkg. I don't recommended it. Because many time the master is got broken.

Copy link
Copy Markdown
Contributor

@talregev talregev Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not wait for every two weeks update? why you want it up to date?

Copy link
Copy Markdown
Collaborator Author

@ProfFan ProfFan Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is broken right now, we can't merge new PRs

Copy link
Copy Markdown
Contributor

@talregev talregev Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a temporary fix that you already merge.
You can rebase this PR to develop branch and undo these changes.


- name: "Install dependencies"
run: >
Expand Down
3 changes: 1 addition & 2 deletions gtsam/3rdparty/cephes/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ set(CEPHES_HEADER_FILES
cephes/lanczos.h
cephes/mconf.h
cephes/polevl.h
cephes/sf_error.h
dllexport.h)
cephes/sf_error.h)

# Add header files
install(FILES ${CEPHES_HEADER_FILES} DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/gtsam/3rdparty/cephes)
Expand Down
Loading