Skip to content

switch Hat/Vee to orthonormal sl(4) basis and update adjoint/tests#2360

Merged
dellaert merged 3 commits intoborglab:developfrom
yluo5820:feature/sl4_hat
Jan 19, 2026
Merged

switch Hat/Vee to orthonormal sl(4) basis and update adjoint/tests#2360
dellaert merged 3 commits intoborglab:developfrom
yluo5820:feature/sl4_hat

Conversation

@yluo5820
Copy link
Copy Markdown
Contributor

Switched SL4’s Lie algebra coordinates from the old “raw off‑diagonal + chained diagonal” parameterization to a geometrically meaningful orthonormal basis. Hat/Vee now decompose sl(4) into 3 parts: 6 skew‑symmetric rotation generators, 6 symmetric off‑diagonal shear generators, and 3 orthonormal traceless diagonal scalings. Updated the adjoint vectorization matrices to match this basis and refreshed tests to validate trace‑zero, round‑trip Hat↔Vee, and orthonormal generator inner products.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copy link
Copy Markdown
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@dellaert dellaert merged commit 039faa8 into borglab:develop Jan 19, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants