Skip to content

Fix segfault in constraint #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dellaert merged 2 commits into from
Feb 1, 2026
Merged

Fix segfault in constraint #2379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be18e64
Add comment
dellaert Feb 1, 2026
9fec242
Fix seg-faulting bug
dellaert Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/HandleGlobalBuildFlags.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if(MSVC AND GTSAM_SHARED_LIB)
endif()

if (APPLE AND GTSAM_SHARED_LIB)
# Set the default install directory on macOS
# Setting to @rpath so that dependent executables can find the GTSAM dylib in a portable manner
set(CMAKE_INSTALL_NAME_DIR "@rpath")
endif()

Expand Down
2 changes: 1 addition & 1 deletion gtsam/constrained/NonlinearEqualityConstraint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Vector NonlinearEqualityConstraints::violationVector(const Values& values, bool
size_t start_idx = 0;
for (const auto& constraint : *this) {
size_t dim = constraint->dim();
violation.middleCols(start_idx, dim) =
violation.segment(start_idx, dim) =
whiten ? constraint->whitenedError(values) : constraint->unwhitenedError(values);
start_idx += dim;
}
Expand Down
Loading