Skip to content

Fix a deadlock under Windows#2393

Merged
dellaert merged 1 commit intodevelopfrom
fan/fix_deadlock
Feb 7, 2026
Merged

Fix a deadlock under Windows#2393
dellaert merged 1 commit intodevelopfrom
fan/fix_deadlock

Conversation

@ProfFan
Copy link
Copy Markdown
Collaborator

@ProfFan ProfFan commented Feb 7, 2026

Fixes #2391

Reason is the condition_variable is not guarded by mutex acquisition.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 7, 2026

timeSFMBAL benchmark

  • Head: d6ea20cb6a00b55a0e884b9ec84c6636e00155d6
  • Base: 2cf30d67e78a6b458688abdf68bde1c79d6c65f1
Runner Metric Base (s) Head (s) Delta (s) Change
linux-arm64 timeSFMBAL/dubrovnik-16-22106-pre.txt/MultifrontalCholesky 1.942374 2.113584 +0.171210 +8.81%
linux-arm64 timeSFMBAL/dubrovnik-16-22106-pre.txt/MultifrontalSolver 1.164656 1.241989 +0.077333 +6.64%
linux-x64 timeSFMBAL/dubrovnik-16-22106-pre.txt/MultifrontalCholesky 2.276776 2.135155 -0.141621 -6.22%
linux-x64 timeSFMBAL/dubrovnik-16-22106-pre.txt/MultifrontalSolver 1.688192 1.541148 -0.147045 -8.71%
macos-arm64 timeSFMBAL/dubrovnik-16-22106-pre.txt/MultifrontalCholesky 1.470405 1.558649 +0.088244 +6.00%
macos-arm64 timeSFMBAL/dubrovnik-16-22106-pre.txt/MultifrontalSolver 1.026638 1.043313 +0.016675 +1.62%

Worker runs

Role Runner SHA Conclusion
head linux-x64 d6ea20cb6a00b55a0e884b9ec84c6636e00155d6 success
base linux-x64 2cf30d67e78a6b458688abdf68bde1c79d6c65f1 success
head linux-arm64 d6ea20cb6a00b55a0e884b9ec84c6636e00155d6 success
base linux-arm64 2cf30d67e78a6b458688abdf68bde1c79d6c65f1 success
head macos-arm64 d6ea20cb6a00b55a0e884b9ec84c6636e00155d6 success
base macos-arm64 2cf30d67e78a6b458688abdf68bde1c79d6c65f1 success

Copy link
Copy Markdown
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@dellaert dellaert merged commit b0522e6 into develop Feb 7, 2026
40 checks passed
@dellaert dellaert deleted the fan/fix_deadlock branch February 7, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scheduler waitForAllTasks can hang randomly

2 participants