Skip to content

Fix a deadlock under Windows #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dellaert merged 1 commit into from
Feb 7, 2026
+6 −1
Merged

Fix a deadlock under Windows #2393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion gtsam/base/Scheduler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ class Scheduler {

// Notify waiters only when work transitions to "done".
if (activeTasks_.fetch_sub(1, std::memory_order_release) == 1) {
std::lock_guard<std::mutex> lock(waitMutex_);
condition_.notify_all();
}
}
Expand Down Expand Up @@ -183,7 +184,10 @@ class Scheduler {

queuedTasks_.fetch_add(1, std::memory_order_release);
activeTasks_.fetch_add(1, std::memory_order_release);
condition_.notify_one();
{
std::lock_guard<std::mutex> lock(waitMutex_);
condition_.notify_one();
}
return true;
}

Expand All @@ -201,6 +205,7 @@ class Scheduler {
} catch (...) { /* ignore */
}
if (activeTasks_.fetch_sub(1, std::memory_order_release) == 1) {
std::lock_guard<std::mutex> lock(waitMutex_);
condition_.notify_all();
}
}
Expand Down
Loading