Skip to content

feat(schedule-actions): wire actions popover on schedule page#1427

Merged
Assem-Uber merged 14 commits into
cadence-workflow:masterfrom
Assem-Uber:feat/schedule-actions-mount
Jul 2, 2026
Merged

feat(schedule-actions): wire actions popover on schedule page#1427
Assem-Uber merged 14 commits into
cadence-workflow:masterfrom
Assem-Uber:feat/schedule-actions-mount

Conversation

@Assem-Uber

@Assem-Uber Assem-Uber commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Mounts the schedule-actions popover and confirmation modal on the schedule page tab bar. Completes the stacked schedule-actions UI started in #1419 and #1426.

Changes

  • schedule-actions/ — client component that loads schedule details, renders the actions popover button, menu, and modal
  • schedule-page-tabs/ — mounts ScheduleActions as the tab bar endEnhancer behind an error boundary
  • __tests__/schedule-actions.test.tsx — loading, error, menu, and modal open/close behavior

Testing

Screenshot 2026-07-01 at 17 13 59 Screenshot 2026-07-01 at 17 14 28
Screen.Recording.2026-07-01.at.17.12.36.mov

Stack

Assem-Uber and others added 7 commits July 1, 2026 15:28
Add schedule-actions modal shell and modal content with config-driven
warning banners, POST submission, cache invalidation, snackbar, and
error handling.

Co-authored-by: Cursor <cursoragent@cursor.com>
Comment thread src/views/schedule-actions/schedule-actions.tsx
Assem-Uber and others added 5 commits July 2, 2026 00:38
Add ScheduleActions orchestrator, pass describe data into the modal, and
mount on schedule page tabs.

Co-authored-by: Cursor <cursoragent@cursor.com>
Replace ScheduleAction<any, any, any> state with SelectableScheduleAction
derived from schedule-actions.config. ErasedScheduleAction cast at the
generic modal boundary only.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gitar-bot

gitar-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Wires the schedule actions popover and confirmation modal into the schedule page tab bar, addressing the missing type safety for the selected action state. No issues found.

✅ 1 resolved
Quality: selectedAction state typed as ScheduleAction

📄 src/views/schedule-actions/schedule-actions.tsx:38-40
The selectedAction state is typed as ScheduleAction<any, any, any>, which erases the generic type parameters (Result, FormData, SubmissionData). This propagates untyped any values down into ScheduleActionsModal and ScheduleActionsModalContent, defeating the generic type-safety those components were designed around (e.g. form data / submission data transformation). Since the action list is heterogeneous, a fully-typed union may not be trivial, but consider defining a ScheduleAction<unknown, unknown, unknown> alias or an explicit discriminated union type for the selectable actions to preserve some safety and make intent clearer. This is a maintainability concern only; behavior is unaffected.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@YoavLev YoavLev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Assem-Uber Assem-Uber merged commit e4c0de7 into cadence-workflow:master Jul 2, 2026
4 checks passed
@Assem-Uber Assem-Uber deleted the feat/schedule-actions-mount branch July 2, 2026 12:15
Assem-Uber added a commit that referenced this pull request Jul 2, 2026
## Summary

Adds the Delete schedule action to the schedule-actions menu as a
confirmation-only modal with a warning banner. On success, the UI
navigates to the schedules list and invalidates `listSchedules`.

Rebased onto `master` after #1427 merged; this PR now contains only the
delete UI slice (4 commits).
Assem-Uber added a commit to Assem-Uber/cadence-web that referenced this pull request Jul 2, 2026
…low#1428)

## Summary

Adds the Delete schedule action to the schedule-actions menu as a
confirmation-only modal with a warning banner. On success, the UI
navigates to the schedules list and invalidates `listSchedules`.

Rebased onto `master` after cadence-workflow#1427 merged; this PR now contains only the
delete UI slice (4 commits).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants