Conversation
Co-authored-by: aider (openai/claude-sonnet-4) <aider@aider.chat>
Co-authored-by: aider (openai/claude-sonnet-4) <aider@aider.chat>
Tsonov
reviewed
Aug 11, 2025
internal/castai/client.go
Outdated
| }) | ||
| } | ||
|
|
||
| if metric.Counter != nil { |
Contributor
There was a problem hiding this comment.
Isn't this redundant, after line 202 you know it's not nil
Tsonov
reviewed
Aug 11, 2025
| log.Fatalf("failed to create castai client: %v", err) | ||
| } | ||
|
|
||
| client := castai.NewClient(logger, cl, cfg.ClusterID) |
Contributor
There was a problem hiding this comment.
This will be empty locally, is it a problem?
Contributor
Author
There was a problem hiding this comment.
The pod_name label value will be empty, but it's not a problem.
Tsonov
reviewed
Aug 11, 2025
| }() | ||
|
|
||
| if cfg.Metrics.ExportEnabled { | ||
| metricExporter := metricexporter.New(log, client, cfg.Metrics.ExportInterval) |
Contributor
There was a problem hiding this comment.
let's add a log that this is enabled so we know
Contributor
Author
There was a problem hiding this comment.
There is a log in metricExporter.Run():
me.log.Infof("starting metrics exporter with interval %v", me.exportInterval)
Contributor
|
As long as we can HARD block a client on the server side (so we don't get ddos, even if it's a mistake), this LGTM |
Tsonov
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds metric export from cluster-controller to Cast AI. It uses the ComponentsAPI IngestMetric endpoint. It gathers metrics registered in the Prometheus client, but right now only Counter metrics and exported (we have just 1 Counter metrics now).
This functionally it disabled by default and can be enabled with
METRICS_EXPORT_ENABLED=trueenvironment variable.