-
Notifications
You must be signed in to change notification settings - Fork 4
feat: export metrics to CastAI #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
cc3f811
add metric exporter goroutine
Trojan295 f917ecf
test: add unit tests for MetricsExporter successful and error paths
Trojan295 445d7a2
add tests
Trojan295 d4b6b13
conditionally run metric exporter
Trojan295 90165c3
test: add unit tests for convertPrometheusMetricFamilies function
Trojan295 86e468b
test converter
Trojan295 ee38748
fix tests
Trojan295 85b5d89
pass the right testing context
Trojan295 3877c2d
add pod_name dimension
Trojan295 fda8e26
fix
Trojan295 deb8d51
remove testing metric
Trojan295 2b41d7d
remove redundant nil check
Trojan295 a23022d
bump github.com/docker/docker library
Trojan295 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| .DS_Store | ||
| .idea | ||
| .run | ||
| *.iml | ||
| bin | ||
| .env | ||
| e2e/**/castai-*.json | ||
|
|
||
| .aider* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,7 @@ import ( | |
| "github.com/castai/cluster-controller/internal/config" | ||
| "github.com/castai/cluster-controller/internal/controller" | ||
| "github.com/castai/cluster-controller/internal/controller/logexporter" | ||
| "github.com/castai/cluster-controller/internal/controller/metricexporter" | ||
| "github.com/castai/cluster-controller/internal/helm" | ||
| "github.com/castai/cluster-controller/internal/k8sversion" | ||
| "github.com/castai/cluster-controller/internal/metrics" | ||
|
|
@@ -55,7 +56,7 @@ func run(ctx context.Context) error { | |
| log.Fatalf("failed to create castai client: %v", err) | ||
| } | ||
|
|
||
| client := castai.NewClient(logger, cl, cfg.ClusterID) | ||
| client := castai.NewClient(logger, cl, cfg.ClusterID, cfg.SelfPod.Name) | ||
|
|
||
| logexporter.SetupLogExporter(logger, client) | ||
|
|
||
|
|
@@ -159,6 +160,11 @@ func runController( | |
| } | ||
| }() | ||
|
|
||
| if cfg.Metrics.ExportEnabled { | ||
| metricExporter := metricexporter.New(log, client, cfg.Metrics.ExportInterval) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's add a log that this is enabled so we know
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a log in me.log.Infof("starting metrics exporter with interval %v", me.exportInterval) |
||
| go metricExporter.Run(ctx) | ||
| } | ||
|
|
||
| httpMux := http.NewServeMux() | ||
| var checks []healthz.HealthChecker | ||
| checks = append(checks, healthzAction) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be empty locally, is it a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
pod_namelabel value will be empty, but it's not a problem.