artifactory-automation: harden shell scripting and fix curl JSON body#339
Merged
hooksie1 merged 1 commit intoMay 20, 2026
Conversation
Fixes a correctness bug where `TOKEN_USER` and `TOKEN_PASSWORD` were never interpolated into the curl request body (single-quote escaping prevented expansion), and hardens the surrounding shell script against word splitting, glob expansion, and malformed JSON payloads. Changes: - Fix curl `-d` body to use `jq -n --arg` for safe, properly escaped JSON serialization - Quote all variable expansions (`$PRUNE`, `$id`, `$PULL_TOKEN_JSON`, `$GITHUB_OUTPUT`, `$RESP`, `$BODY`) - Add `[[ -n "$id" ]] || continue` guard in the token pruning loop - Use `set +x` before writing the pull token password to `$GITHUB_OUTPUT` to prevent it appearing in Actions debug logs - Switch HTTP status check from arithmetic `-ne` to string `!=` to handle empty/non-numeric values gracefully - Capitalize "Artifactory" consistently in all input descriptions
hooksie1
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a correctness bug where
TOKEN_USERandTOKEN_PASSWORDwere never interpolated into the curl request body (single-quote escaping prevented expansion), and hardens the surrounding shell script against word splitting, glob expansion, and malformed JSON payloads.Changes:
-dbody to usejq -n --argfor safe, properly escaped JSON serialization$PRUNE,$id,$PULL_TOKEN_JSON,$GITHUB_OUTPUT,$RESP,$BODY)[[ -n "$id" ]] || continueguard in the token pruning loopset +xbefore writing the pull token password to$GITHUB_OUTPUTto prevent it appearing in Actions debug logs-neto string!=to handle empty/non-numeric values gracefully