Skip to content

artifactory-automation: harden shell scripting and fix curl JSON body #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hooksie1 merged 1 commit into from
May 20, 2026
Merged

artifactory-automation: harden shell scripting and fix curl JSON body #339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 24 additions & 22 deletions artifactory-automation/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,19 @@ inputs:
required: true

artifactory_url:
description: 'The url to your artifactory instance'
description: 'The URL to your Artifactory instance'
required: true

artifactory_user:
description: 'The username for artifactory'
description: 'The username for Artifactory'
required: true

artifactory_repository_name:
description: 'The name of the artifactory repository to update'
description: 'The name of the Artifactory repository to update'
required: true

artifactory_token:
description: 'API token for deployment'
description: 'Artifactory API token for deployment'
required: true

ttl:
Expand All @@ -33,7 +33,7 @@ inputs:
default: 168h

prune_expired:
description: 'Prune expired tokens (requires identity.list, identity.delete permissions)'
description: 'Prune expired Artifactory tokens (requires identity.list, identity.delete permissions)'
required: false
default: "false"

Expand All @@ -55,20 +55,22 @@ runs:
TTL: ${{ inputs.ttl }}
PRUNE: ${{ inputs.prune_expired }}
run: |
if [[ $PRUNE = "true" ]]; then
if [[ "$PRUNE" = "true" ]]; then
for id in $(chainctl iam identities list --parent "$ORGANIZATION" --name "pull token - registry" --expired -o json | jq -r '.items[]?.id'); do
[[ -n "$id" ]] || continue
echo "Deleting old pull token $id"
chainctl iam identities delete $id --parent "$ORGANIZATION" -y
done
chainctl iam identities delete "$id" --parent "$ORGANIZATION" -y
done
fi

PULL_TOKEN_JSON=$(chainctl auth pull-token --ttl "$TTL" --output json)

user=$(jq -r '.identity_id' <<<$PULL_TOKEN_JSON)
password=$(jq -r '.token' <<<$PULL_TOKEN_JSON)
user=$(jq -r '.identity_id' <<<"$PULL_TOKEN_JSON")
password=$(jq -r '.token' <<<"$PULL_TOKEN_JSON")

echo "user=$user" >> $GITHUB_OUTPUT
echo "password=$password" >> $GITHUB_OUTPUT
echo "user=$user" >> "$GITHUB_OUTPUT"
set +x
echo "password=$password" >> "$GITHUB_OUTPUT"

- name: Update Artifactory Registry
shell: bash
Expand All @@ -86,18 +88,18 @@ runs:
-X POST \
"$ARTIFACTORY_URL/artifactory/api/repositories/$ARTIFACTORY_REPOSITORY_NAME" \
-H "Content-Type: application/json" \
-d '{
"key": "'$ARTIFACTORY_REPOSITORY_NAME'",
"username": "'$TOKEN_USER'",
"password": "'$TOKEN_PASSWORD'"
}')
-d "$(jq -n \
--arg key "$ARTIFACTORY_REPOSITORY_NAME" \
--arg user "$TOKEN_USER" \
--arg pass "$TOKEN_PASSWORD" \
'{"key":$key,"username":$user,"password":$pass}')")

BODY=$(echo $RESP | sed -e 's/HTTPSTATUS\:.*//g')
STATUS=$(echo $RESP | tr -d '\n' | sed -e 's/.*HTTPSTATUS://')
BODY=$(echo "$RESP" | sed -e 's/HTTPSTATUS\:.*//g')
STATUS=$(echo "$RESP" | tr -d '\n' | sed -e 's/.*HTTPSTATUS://')

if [ "$STATUS" -ne 200 ]; then
echo "Error $STATUS": $BODY
if [[ "$STATUS" != '200' ]]; then
echo "Error ${STATUS}: $BODY"
exit 1
fi

echo $BODY
echo "$BODY"
Loading