Update project description, reorg modules#5
Merged
Merged
Conversation
Contributor
kaitj
commented
Jan 29, 2026
kaitj
commented
- Removed some of the unnecessary bits of the description
- Reorganized modules to add functional and removed unnecessary "modalities"
- Removed mention of "derivative" as this is implied. - Similarly mention of longitudinal is not strictly necessary.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This was referenced Feb 2, 2026
kaitj
added a commit
that referenced
this pull request
Feb 2, 2026
* Update project description - Removed mention of "derivative" as this is implied. - Similarly mention of longitudinal is not strictly necessary. * Remove structural modules * Add functional module
kaitj
added a commit
that referenced
this pull request
Feb 2, 2026
* Update project description - Removed mention of "derivative" as this is implied. - Similarly mention of longitudinal is not strictly necessary. * Remove structural modules * Add functional module
nx10
added a commit
that referenced
this pull request
Apr 15, 2026
Tissue masks (csf/gm/wm) were being warped into longitudinal template space even though nothing downstream consumes them there; per Jason's handover note #5 this is wasted work. Removes the fields from `AnatomicalLongOutputs`, the `_xfm()` calls in `longitudinal_process`, and the matching resolve/export entries under `space-longitudinal`. Adds a unit test asserting the tissue masks are not produced, and trims the three obsolete rows from `docs/data_dictionary.md`.
11 tasks
nx10
added a commit
that referenced
this pull request
Apr 15, 2026
…314) * Drop tissue-mask transforms from longitudinal anat (Stage 4 of #301) Tissue masks (csf/gm/wm) were being warped into longitudinal template space even though nothing downstream consumes them there; per Jason's handover note #5 this is wasted work. Removes the fields from `AnatomicalLongOutputs`, the `_xfm()` calls in `longitudinal_process`, and the matching resolve/export entries under `space-longitudinal`. Adds a unit test asserting the tissue masks are not produced, and trims the three obsolete rows from `docs/data_dictionary.md`. * Tighten Stage 4 tests (PR review fixups) - Flag the xfm filename quirk (space-longitudinal + from-/to- is redundant) with a comment pointing at handover note #18, so the hard-coded expected names are not mistaken for a spec. - Replace the Mock-based longitudinal anat outputs in the orchestration tests with a real AnatomicalLongOutputs NamedTuple so attribute typos fail loudly instead of silently returning a new Mock. - Add resolve_longitudinal_anat unit tests covering the happy path, brain_mask optionality, and bids_safe_label round-trip for session labels with non-alphanumerics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.