Skip to content

Update project description, reorg modules#5

Merged
nx10 merged 3 commits into
mainfrom
maint/cleanup
Jan 29, 2026
Merged

Update project description, reorg modules#5
nx10 merged 3 commits into
mainfrom
maint/cleanup

Conversation

@kaitj
Copy link
Copy Markdown
Contributor

@kaitj kaitj commented Jan 29, 2026

  • Removed some of the unnecessary bits of the description
  • Reorganized modules to add functional and removed unnecessary "modalities"

- Removed mention of "derivative" as this is implied.
- Similarly mention of longitudinal is not strictly necessary.
@kaitj kaitj requested a review from nx10 January 29, 2026 14:46
@kaitj kaitj self-assigned this Jan 29, 2026
@nx10 nx10 merged commit ac7b2bb into main Jan 29, 2026
2 of 4 checks passed
@nx10 nx10 deleted the maint/cleanup branch January 29, 2026 21:00
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

kaitj added a commit that referenced this pull request Feb 2, 2026
* Update project description

- Removed mention of "derivative" as this is implied.
- Similarly mention of longitudinal is not strictly necessary.

* Remove structural modules

* Add functional module
kaitj added a commit that referenced this pull request Feb 2, 2026
* Update project description

- Removed mention of "derivative" as this is implied.
- Similarly mention of longitudinal is not strictly necessary.

* Remove structural modules

* Add functional module
nx10 added a commit that referenced this pull request Apr 6, 2026
- Resolve merge conflicts (keep orchestration layer, discard old inline logic)
- Fix docstring paths in generate_bids_tools.py (#1)
- Remove redundant extension=Extension.NII_GZ in longitudinal export (#5)
- Clarify verbose docstring in RunnerConfig (#6)
nx10 added a commit that referenced this pull request Apr 15, 2026
Tissue masks (csf/gm/wm) were being warped into longitudinal template
space even though nothing downstream consumes them there; per Jason's
handover note #5 this is wasted work. Removes the fields from
`AnatomicalLongOutputs`, the `_xfm()` calls in `longitudinal_process`,
and the matching resolve/export entries under `space-longitudinal`.

Adds a unit test asserting the tissue masks are not produced, and trims
the three obsolete rows from `docs/data_dictionary.md`.
nx10 added a commit that referenced this pull request Apr 15, 2026
…314)

* Drop tissue-mask transforms from longitudinal anat (Stage 4 of #301)

Tissue masks (csf/gm/wm) were being warped into longitudinal template
space even though nothing downstream consumes them there; per Jason's
handover note #5 this is wasted work. Removes the fields from
`AnatomicalLongOutputs`, the `_xfm()` calls in `longitudinal_process`,
and the matching resolve/export entries under `space-longitudinal`.

Adds a unit test asserting the tissue masks are not produced, and trims
the three obsolete rows from `docs/data_dictionary.md`.

* Tighten Stage 4 tests (PR review fixups)

- Flag the xfm filename quirk (space-longitudinal + from-/to- is
  redundant) with a comment pointing at handover note #18, so the
  hard-coded expected names are not mistaken for a spec.
- Replace the Mock-based longitudinal anat outputs in the orchestration
  tests with a real AnatomicalLongOutputs NamedTuple so attribute typos
  fail loudly instead of silently returning a new Mock.
- Add resolve_longitudinal_anat unit tests covering the happy path,
  brain_mask optionality, and bids_safe_label round-trip for session
  labels with non-alphanumerics.
gkiar pushed a commit that referenced this pull request May 23, 2026
Renames tests/data/cpac_rbc_divergences.md to docs/cpac_comparison.md
and splits findings into Bugs (#4, #5) and Divergences (#1, #2, #3, #6)
to distinguish unambiguous numerical errors from defensible design
choices. Adds a new divergence about CPAC's duplicate motion correction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants