Fix prefix_macros.sh to handle .svh headers, pic_map_auto.h, and RV_BUILD_AHB_LITE macro#449
Open
MainakSil wants to merge 1 commit into
Open
Fix prefix_macros.sh to handle .svh headers, pic_map_auto.h, and RV_BUILD_AHB_LITE macro#449MainakSil wants to merge 1 commit into
MainakSil wants to merge 1 commit into
Conversation
Author
|
Requesting reviewers to provide the approving review. |
…UILD_AHB_LITE macro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several missing cases in
tools/prefix_macros.shthat can lead to naming conflicts when multiple VeeR instances are used in the same design.Changes
1. Support for additional file types
Extended file matching to include:
.svh.hEnsures all relevant SystemVerilog header files are processed.
2. Fix for
pic_map_auto.hpic_map_auto.h→pic_map_auto.svh3. Handle
.svhinclude filesel2_dec_csr_equ_*.svh) are uniquely prefixed`includestatements in RTL sources4. Explicit handling of
RV_BUILD_AHB_LITE`ifdefconditions)Motivation
The current script misses certain headers and macros, which can cause:
This PR ensures consistent and complete prefixing across all relevant design artifacts.
Notes
Testing
.sv,.vh,.svh, and.hfilespic_map_auto