Skip to content

Adding Makefile common.mk and Python script to generate run_local_regression.sh#469

Open
jinalhpatel wants to merge 3 commits into
chipsalliance:mainfrom
jinalhpatel:dcls_local_regression_run
Open

Adding Makefile common.mk and Python script to generate run_local_regression.sh#469
jinalhpatel wants to merge 3 commits into
chipsalliance:mainfrom
jinalhpatel:dcls_local_regression_run

Conversation

@jinalhpatel

@jinalhpatel jinalhpatel commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Makefile :
containing make command target for software and block level test
also target for local regression run

gen_ci_testlist.py:
work is in progress to enhance require run_local_regression.sh

common.mk :
Added fsdb generation with WAVES=1, for verification/block/$TEST

@jinalhpatel jinalhpatel requested a review from samipmodi323 June 24, 2026 00:09
@github-actions

Copy link
Copy Markdown

Coverage dashboard artifact for this PR is available in the CI run

@github-actions

Copy link
Copy Markdown

Coverage dashboard artifact for this PR is available in the CI run

@jinalhpatel jinalhpatel requested a review from moidx June 24, 2026 17:56
@jinalhpatel jinalhpatel marked this pull request as ready for review June 24, 2026 17:57
samipmodi323
samipmodi323 previously approved these changes Jun 29, 2026

@samipmodi323 samipmodi323 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gen_ci_testlist.py - ok.
Makefile - ok

Comment thread Makefile Outdated
Comment on lines +2 to +3
# Copyright 2020 Western Digital Corporation or its affiliates.
# Copyright 2024 Antmicro <www.antmicro.com>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these two copyrights are these contributions are from Google.

Comment thread Makefile
Comment thread .github/scripts/gen_ci_testlist.py
Comment thread Makefile Outdated
Comment on lines +84 to +88
#Example make command to run single test without run_regress_test.sh#
#make snapshot="caliptra-core" TEST=ecc debug=1 SIMULATOR=vcs
#
#Example make command to run single test with run_regress_test.sh#
#make run_reg_test TEST=dcls COVERAGE=all SIMULATOR=vcs

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to the beginning of the file as instructions on how to use this Makefile, and describe what run_reg_test does.

e.g.

# Example make command to run single test
# make snapshot="caliptra-core" TEST=ecc debug=1 SIMULATOR=vcs
#
# Example make command to run single test with run_regress_test
# make run_reg_test TEST=dcls COVERAGE=all SIMULATOR=vcs

@moidx

moidx commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Hi @jinalhpatel, please amend your commit and force push once you are done addressing the feedback. You will also have to rebase against the main branch to resolve the out-of-date issue. Thanks

…gression.sh

Signed-off-by: Jinalben Patel <jinalben@google.com>
@jinalhpatel jinalhpatel force-pushed the dcls_local_regression_run branch from bba3134 to 6f63c4c Compare June 30, 2026 07:38
@jinalhpatel jinalhpatel changed the title Adding Makefile and Python script to generate run_local_regression.sh Adding Makefile common.mk and Python script to generate run_local_regression.sh Jun 30, 2026
@github-actions

Copy link
Copy Markdown

Coverage dashboard artifact for this PR is available in the CI run

@moidx

moidx commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Hi @jinalhpatel we want to avoid having merge commits to maintain a clean git history. Please revert the merge commit and do something like this to rebase:

git fetch upstream
git pull --rebase upstream main
# Resolve any issues if needed. You may have to use git rebase --continue 
git push -f dcls_local_regression_run

Use origin instead of upstream if you are not working from a fork.

Thanks

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Coverage dashboard artifact for this PR is available in the CI run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants