Add support for configurable warnings (backport #3414) #3430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3414 done by Mergify.
Cherry-pick of 8e33a68 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com
Original PR Body
Currently opened as a draft but I would like to get the ball rolling on this.
This is heavily inspired by configurable warnings in Scala, but is a little more limited.
TODO
Make new warnings more clear that they are deprecationsI'm going to do this in a follow on PR--warn-conf-filewhich is the same syntax but with\nseparated pairs in a file rather than,separated pairs in a String.--warn-conf-filewith--warn-confThe commit text gives a pretty good overview:
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Add support for configurable warnings, see https://www.chisel-lang.org/chisel3/docs/explanations/warnings.html
Reviewer Checklist (only modified by reviewer)
3.5.x,3.6.x, or5.xdepending on impact, API modification or big change:6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.