[VeriblePreProcessor][3]: Passing macros defined using "+define" to "VerilogPreprocess" class #1374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o generate all variants with the new mode generate-variants
…ass for the moment.
"verible::CmdPositionalArguments" class only supports these types so far: SV files, +define+<name>[=<value>], and +incdir+<dir>.
hzeller
reviewed
Aug 15, 2022
Collaborator
hzeller
left a comment
hzeller
left a comment
There was a problem hiding this comment.
Since this contains a lot of the changes of the previous PRs, let's first finish the previous ones to reduce the potential merge headaches.
| // add the macro definition to memeory. | ||
| RegisterMacroDefinition(macro_definition); | ||
|
|
||
| return absl::OkStatus(); |
Collaborator
There was a problem hiding this comment.
If this only ever returns 'ok status' anyway, let's not bother with error handling for now and just have it a void function.
Contributor
Author
|
Closed as a duplicate of #1424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a part of the sequentially splitted PRs from PR #1360.
Description:
Adding an interface function
AddDefineFromCmdLineto use the macros added by+define+\<foo>argument toVerilogPreprocess.