-
Notifications
You must be signed in to change notification settings - Fork 264
Initial version of a devcontainer for Verible #2068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version of a devcontainer for Verible #2068
Conversation
|
@hzeller : Can you review and consider approving? |
|
@corco: Please let me know if there are any other changes needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2068 +/- ##
=======================================
Coverage 92.95% 92.95%
=======================================
Files 358 358
Lines 26446 26446
=======================================
Hits 24583 24583
Misses 1863 1863 ☔ View full report in Codecov by Sentry. |
|
Hi @corco : I don't have write access to the repo, so I can't merge this PR. Can you please merge it or grant me write access? Thanks. |
|
Can you add a README to the directory that explains what this is for possibly with links pointing to documentation ? |
|
Please add the environment variable |
|
Recent changes should make it possible to compile with Bazel 7, so maybe the Since I can't test the devcontainer stuff I can't test that myself. Passing on to @corco (who can have a look next week when back) @kbrunham-intel : can you add a README in the directory briefly explaining what it is for ? |
|
@hzeller : Please approve this PR and then merge it. I don't have write access to this repo. |
hzeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Even though it is for a specific editor, it does not seem to be to much of an additional burden to maintain(I usually would recommend just using the shell.nix for the relevant dependencies).
Anyway, before merge I'd remove the comments in the json file first, as the json spec does not allow for comments.
Just add the relevant link in the README.md, e.g.
"The Dockerfile defines the environment to use, with json configuration according to https://aka.ms/devcontainer.json for the VSCode editor".
|
Thanks, merged. |
Initial version of the .devcontainer/ directory and configuration.
This devcontainer uses a Dockerfile based on the Microsoft CPP container, augmented to install Bazel, clang-format, and clang-tidy.
With the devcontainer, developers can clone the repo, and open it within a standard container definition.