Skip to content

Conversation

@kbrunham-intel
Copy link
Contributor

Initial version of the .devcontainer/ directory and configuration.

This devcontainer uses a Dockerfile based on the Microsoft CPP container, augmented to install Bazel, clang-format, and clang-tidy.

With the devcontainer, developers can clone the repo, and open it within a standard container definition.

@kbrunham-intel
Copy link
Contributor Author

@hzeller : Can you review and consider approving?

@kbrunham-intel
Copy link
Contributor Author

@corco: Please let me know if there are any other changes needed.

@kbrunham-intel kbrunham-intel requested a review from corco January 13, 2024 21:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4d61b1) 92.95% compared to head (4522d99) 92.95%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2068   +/-   ##
=======================================
  Coverage   92.95%   92.95%           
=======================================
  Files         358      358           
  Lines       26446    26446           
=======================================
  Hits        24583    24583           
  Misses       1863     1863           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbrunham-intel
Copy link
Contributor Author

Hi @corco : I don't have write access to the repo, so I can't merge this PR. Can you please merge it or grant me write access?

Thanks.

@corco corco closed this Jan 17, 2024
@corco corco reopened this Jan 17, 2024
@kbrunham-intel
Copy link
Contributor Author

@corco / @hzeller : Please merge as I don't have write access.

@hzeller
Copy link
Collaborator

hzeller commented Jan 19, 2024

Can you add a README to the directory that explains what this is for possibly with links pointing to documentation ?
It looks like a editor configuration for a specific (vscode ?); so for everyone else they then can see if this is relevant for them.

@corco
Copy link
Collaborator

corco commented Jan 31, 2024

Please add the environment variable USE_BAZEL_VERSION with value "6.5.0" in the devcontainer.json. Right now the devcontainer would use bazel 7.0 which is not able to compile verible. That environment variable should make it use a compatible bazel version

@hzeller
Copy link
Collaborator

hzeller commented Mar 7, 2024

Recent changes should make it possible to compile with Bazel 7, so maybe the USE_BAZEL_VERSION might not be needed.

Since I can't test the devcontainer stuff I can't test that myself. Passing on to @corco (who can have a look next week when back)

@kbrunham-intel : can you add a README in the directory briefly explaining what it is for ?

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 8, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@kbrunham-intel
Copy link
Contributor Author

@hzeller : Please approve this PR and then merge it. I don't have write access to this repo.

Copy link
Collaborator

@hzeller hzeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Even though it is for a specific editor, it does not seem to be to much of an additional burden to maintain(I usually would recommend just using the shell.nix for the relevant dependencies).

Anyway, before merge I'd remove the comments in the json file first, as the json spec does not allow for comments.
Just add the relevant link in the README.md, e.g.
"The Dockerfile defines the environment to use, with json configuration according to https://aka.ms/devcontainer.json for the VSCode editor".

@hzeller hzeller merged commit 0a93553 into chipsalliance:master Dec 12, 2025
33 checks passed
@hzeller
Copy link
Collaborator

hzeller commented Dec 12, 2025

Thanks, merged.

@kbrunham-intel kbrunham-intel deleted the feat/devcontainer_dec23 branch December 12, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants