Skip to content

Resolve "Rejected valid signal name" #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matlupi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Resolve "Rejected valid signal name" #2102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f287035
ML fixed #2076
matlupi Feb 6, 2024
72ff5ce
ML added testcase for #2076
matlupi Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions verilog/parser/verilog.y
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,8 @@ KeywordIdentifier
{ $$ = std::move($1); }
| TK_discrete
{ $$ = std::move($1); }
| TK_analog
{ $$ = std::move($1); }
/* TK_sample is in SystemVerilog coverage_event */
| TK_sample
{ $$ = std::move($1); }
Expand Down
1 change: 1 addition & 0 deletions verilog/parser/verilog_parser_unittest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1773,6 +1773,7 @@ static constexpr ParserTestCaseArray kModuleTests = {
// keyword tests
"module keyword_identifiers;\n"
"reg branch; // branch is a Verilog-AMS keyword\n"
"reg analog; // analog is a Verilog-AMS keyword\n"
"input from; // from is a Verilog-AMS keyword\n"
"wire access; // access is a Verilog-AMS keyword\n"
"wire exclude; // exclude is a Verilog-AMS keyword\n"
Expand Down