fixe #2278 #2312
Open
fixe #2278 #2312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
requested changes
Dec 24, 2024
Collaborator
hzeller
left a comment
hzeller
left a comment
There was a problem hiding this comment.
First round of comments
| std::string description; | ||
| }; | ||
|
|
||
| struct LintRuleDescriptor { |
Collaborator
There was a problem hiding this comment.
where did this one go ? Looks like the end of the file was accidentally deleted ?
| } // namespace verilog | ||
|
|
||
| #endif // VERIBLE_VERILOG_ANALYSIS_DESCRIPTIONS_H_ | ||
| std::string format_long_description(const std::string& description) { |
Collaborator
There was a problem hiding this comment.
This needs a unit test.
The naming convention for functions is typically CamelCase, so here FormatLongDescription()
| } // namespace verilog | ||
|
|
||
| #endif // VERIBLE_VERILOG_ANALYSIS_DESCRIPTIONS_H_ | ||
| std::string format_long_description(const std::string& description) { |
Collaborator
There was a problem hiding this comment.
if you pass in an absl::string_view, your operations below will be cheaper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve lint rule help
fix issue: #2278