fix: #2171 #2314
fix: #2171 #2314
Conversation
fangism
left a comment
fangism
left a comment
There was a problem hiding this comment.
Great start, thank you for working on this!
| std::string description; | ||
| }; | ||
|
|
||
| struct LintRuleDescriptor { |
There was a problem hiding this comment.
Did you mean to delete this?
| } // namespace verilog | ||
|
|
||
| #endif // VERIBLE_VERILOG_ANALYSIS_DESCRIPTIONS_H_ | ||
| std::string format_long_description(const std::string& description) { |
There was a problem hiding this comment.
Is this new function used anywhere? If so, you may declare it in a .h file, but define it in the corresponding .cc file.
There was a problem hiding this comment.
This file doesn't look like it should be added in this PR.
(I'm not familiar with VSCode and how this should work. Perhaps someone else can comment?)
There was a problem hiding this comment.
Are you missing the change to the verilog-preprocess.h that includes the new condition_stack_ class member and AnnotatePreprocessorDirectives method?
| } // namespace | ||
| } // namespace verilog | ||
|
|
||
| TEST(PreprocessorAnnotationTest, AnnotatesConditionals) { |
There was a problem hiding this comment.
Nice test!
I suggest adding tests to cover ifndef and elsif as well.
|
What is the status of this ? Looks like you were on a good track, just some lines got accidentally deleted. |
3 participants
fix issue: #2171