Skip to content

Simplify #if defined(foo) to #ifdef #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hzeller merged 1 commit into from
Dec 22, 2025
Merged

Simplify #if defined(foo) to #ifdef #2483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion verible/common/util/init-command-line.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ std::vector<std::string_view> InitCommandLine(

// Print stacktrace on issue, but not if --config=asan
// which comes with its own stacktrace handling.
#if !defined(__SANITIZE_ADDRESS__)
#ifndef __SANITIZE_ADDRESS__
absl::FailureSignalHandlerOptions options;
absl::InstallFailureSignalHandler(options);
#endif
Expand Down
8 changes: 4 additions & 4 deletions verible/verilog/analysis/lint-rule-registry_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ TEST(LintRuleRegistryTest, CreateTreeLintRuleInvalid) {
TEST(LintRuleRegistryTest, CreateTreeLintRuleValid) {
auto any_rule = CreateSyntaxTreeLintRule("test-rule-1");
EXPECT_NE(any_rule, nullptr);
#if defined(__GXX_RTTI)
#ifdef __GXX_RTTI
auto rule_1 = dynamic_cast<TreeRule1 *>(any_rule.get());
EXPECT_NE(rule_1, nullptr);
#endif
Expand Down Expand Up @@ -155,7 +155,7 @@ TEST(LintRuleRegistryTest, CreateTokenLintRuleInvalid) {
TEST(LintRuleRegistryTest, CreateTokenLintRuleValid) {
auto any_rule = CreateTokenStreamLintRule("token-rule-1");
EXPECT_NE(any_rule, nullptr);
#if defined(__GXX_RTTI)
#ifdef __GXX_RTTI
auto rule_1 = dynamic_cast<TokenRule1 *>(any_rule.get());
EXPECT_NE(rule_1, nullptr);
#endif
Expand Down Expand Up @@ -204,7 +204,7 @@ TEST(LintRuleRegistryTest, CreateLineLintRuleInvalid) {
TEST(LintRuleRegistryTest, CreateLineLintRuleValid) {
auto any_rule = CreateLineLintRule("line-rule-1");
EXPECT_NE(any_rule, nullptr);
#if defined(__GXX_RTTI)
#ifdef __GXX_RTTI
auto rule_1 = dynamic_cast<LineRule1 *>(any_rule.get());
EXPECT_NE(rule_1, nullptr);
#endif
Expand Down Expand Up @@ -253,7 +253,7 @@ TEST(LintRuleRegistryTest, CreateTextLintRuleInvalid) {
TEST(LintRuleRegistryTest, CreateTextLintRuleValid) {
auto any_rule = CreateTextStructureLintRule("text-rule-1");
EXPECT_NE(any_rule, nullptr);
#if defined(__GXX_RTTI)
#ifdef __GXX_RTTI
auto rule_1 = dynamic_cast<TextRule1 *>(any_rule.get());
EXPECT_NE(rule_1, nullptr);
#endif
Expand Down