Fix formatter spacing around path separators in macro arguments - #2577
Open
kbrunham-intel wants to merge 2 commits into
Open
Fix formatter spacing around path separators in macro arguments#2577kbrunham-intel wants to merge 2 commits into
kbrunham-intel wants to merge 2 commits into
Conversation
The formatter treated path separators as division operators, turning `PATH/src/file.sv into `PATH / src / file.sv and breaking compiles (issue chipsalliance#2352).
kbrunham-intel
marked this pull request as ready for review
August 18, 2026 00:55
Contributor
Author
|
Hi @hzeller. Please consider this change which addresses issue 2352 with the formatter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/between identifiers in macro arguments as a division operator.`PROJECT_INCLUDE(`PATH_MY_MODULE/src/config_class.sv)stay compact instead of becoming`PATH_MY_MODULE / src / config_class.sv, which does not compile.assign x = a/b;still becomesa / b).Fixes #2352
Test plan
bazel test -c opt //verible/verilog/formatting:token-annotator_test //verible/verilog/formatting:formatter_test/