Prefer clang-format-19 in run-format.sh - #2582
Open
kbrunham-intel wants to merge 1 commit into
Open
Conversation
CI formats with clang-format-19. The script used to fall back to clang-format-17, which rewrote files that were already clean on master (issue chipsalliance#2580).
kbrunham-intel
marked this pull request as ready for review
August 18, 2026 01:41
Contributor
Author
|
Hi @hzeller. Please consider this change. It helps developers (like me) run the run-format.sh script and not see unneeded changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/bin/run-format.shon currentmasterwith clang-format-19 (the version CI installs). No*.h/*.ccfiles changed; the tree is already clean for CI.run-format.shmatches CI and is a no-op onmaster.Fixes #2580
Test plan
CLANG_FORMAT=clang-format-19 .github/bin/run-format.shleaves the tree unchangedCLANG_FORMATnow selects clang-format-19 and leaves the tree unchangedCLANG_FORMAT=clang-format-17 .github/bin/run-format.shstill rewrites the eight files from run-format.sh rewrites files; the repo should already be fully formatted #2580 (not included in this PR; those diffs would fail CI)