Override style guide citations #817
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
pawelsag
force-pushed
the
psagan/override_style_guide
branch
from
c0764fa to
198b208
Compare
hzeller
reviewed
May 19, 2021
Collaborator
hzeller
left a comment
hzeller
left a comment
There was a problem hiding this comment.
First quick round of comments.
verilog/analysis/verilog_linter.cc
Outdated
| return absl::OkStatus(); | ||
| } | ||
|
|
||
| static void AppendCitation(CustomCitationMap& citations, |
Collaborator
There was a problem hiding this comment.
Output parameters should usually be at the end;
Also it is custom in this code-base to have output parameters pointers instead of references, but given that this is a static helper function used right afterwards, the confusion about it being a reference is probably not that big, so if you really prefer the reference, keep it :)
hzeller
reviewed
May 19, 2021
added 6 commits
May 21, 2021 17:10
…function that parse the citations file
pawelsag
force-pushed
the
psagan/override_style_guide
branch
from
b58a5b3 to
565ee92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Override style-guide citation links and references #519