Skip to content

[ENH]: SysDb should return lineage, version file paths and root collection ID on collections #4557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented May 15, 2025

Description of changes

See title. Needed for garbage collector tests.

Test plan

How are these changes tested?

Updated existing Go tests to cover changes on Go side. Rust changes will be consumed in a future PR.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

n/a

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb marked this pull request as ready for review May 15, 2025 20:05
Copy link
Contributor

propel-code-bot bot commented May 15, 2025

Enhance SysDb to Return File Paths and Root Collection ID

This PR enhances the Collection struct to include version file paths, lineage file paths, and root collection ID fields. These attributes are returned from SysDb and are needed for garbage collector tests. The changes affect both Rust and Go codebases, with appropriate type updates (using Option in Rust and pointer types in Go).

Key Changes:
• Added version_file_path, root_collection_id, and lineage_file_path fields to Collection struct in Rust
• Updated Go structs to use pointer types (*string) for lineage_file_name and root_collection_id
• Modified protocol buffer definition to include new optional fields
• Updated DB queries to properly handle null values

Affected Areas:
• Rust types package (collection.rs)
• Go database models and converters
• SysDb protobuf definitions
• Table catalog implementation

This summary was automatically generated by @propel-code-bot

Copy link
Contributor Author

@codetheweb codetheweb force-pushed the feat-return-collection-with-version-file-lineage-file-root-collection-2 branch from 8a3421d to 972427e Compare May 15, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant