Skip to content

[ENH]: add batch get version file paths method to Sysdb #4432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented May 3, 2025

Description of changes

Needed when garbage collecting a collection in a fork tree, because we need to read the version files of all other nodes in the tree.

Test plan

How are these changes tested?

Added a test.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

n/a

Copy link

github-actions bot commented May 3, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb force-pushed the feat-sysdb-batch-get-version-file-paths-method branch from ab87d31 to 7e6889e Compare May 5, 2025 19:36
Copy link
Contributor Author

codetheweb commented May 5, 2025

@codetheweb codetheweb force-pushed the feat-sysdb-batch-get-version-file-paths-method branch from 4d29f0d to 0d136b9 Compare May 8, 2025 23:30
Copy link
Contributor

propel-code-bot bot commented May 8, 2025

Add Batch Get Version File Paths Method to Sysdb API (Rust/Go)

This PR introduces a new batch_get_collection_version_file_paths method to the Sysdb system in both Rust and Go, enabling clients to retrieve version file paths for multiple collection IDs in one request. The change modifies API layers end-to-end: protocol buffer definition, Go DB/data access, service and coordinator logic, and their test coverage. It mainly supports garbage collection and related collection tree operations by streamlining access to version files.

Key Changes:
• New protobuf messages and SysDB RPC: BatchGetCollectionVersionFilePathsRequest/Response, RPC added to coordinator.proto.
• Go backend: Implemented BatchGetCollectionVersionFilePaths throughout collectionDb, DAO, coordinator, and catalog; expanded mocks and unit/integration tests.
• Rust client and API: Added BatchGetCollectionVersionFilePathsError type and matching async method for Sysdb, plus implementation for gRPC/Test backends.
• Test coverage added (Go and Rust) for the new API.
• All plumbing wired through coordinator, service, and DB layers to support efficient multi-collection version file path retrieval.

Affected Areas:
• Sysdb API (IDL/protobuf)
• Go sysdb coordinator, catalog, dbmodel, DAO, grpc service, and mocks
• Rust sysdb client (sysdb.rs, test_sysdb.rs)
• Associated tests in Go and Rust

This summary was automatically generated by @propel-code-bot

@codetheweb codetheweb force-pushed the feat-sysdb-batch-get-version-file-paths-method branch 3 times, most recently from 93be17d to ea366a5 Compare May 15, 2025 20:11
@codetheweb codetheweb changed the base branch from main to feat-return-collection-with-version-file-lineage-file-root-collection-2 May 15, 2025 20:11
@codetheweb codetheweb force-pushed the feat-return-collection-with-version-file-lineage-file-root-collection-2 branch from b39fd56 to 8a3421d Compare May 15, 2025 22:38
@codetheweb codetheweb force-pushed the feat-sysdb-batch-get-version-file-paths-method branch from ea366a5 to edf6743 Compare May 15, 2025 22:38
@codetheweb codetheweb force-pushed the feat-return-collection-with-version-file-lineage-file-root-collection-2 branch from 8a3421d to 972427e Compare May 15, 2025 23:34
@codetheweb codetheweb force-pushed the feat-sysdb-batch-get-version-file-paths-method branch 4 times, most recently from 505c4ae to 3ece42b Compare May 16, 2025 16:41
@codetheweb codetheweb force-pushed the feat-return-collection-with-version-file-lineage-file-root-collection-2 branch from 972427e to bab5b68 Compare May 19, 2025 23:38
@codetheweb codetheweb force-pushed the feat-sysdb-batch-get-version-file-paths-method branch from 3ece42b to 5801be6 Compare May 19, 2025 23:38
@codetheweb codetheweb requested a review from sanketkedia May 19, 2025 23:45
@codetheweb codetheweb force-pushed the feat-sysdb-batch-get-version-file-paths-method branch from 5801be6 to 90ac80a Compare May 19, 2025 23:45
@codetheweb codetheweb force-pushed the feat-return-collection-with-version-file-lineage-file-root-collection-2 branch from bab5b68 to 5f7fa4a Compare May 20, 2025 18:02
@codetheweb codetheweb force-pushed the feat-sysdb-batch-get-version-file-paths-method branch from 90ac80a to 2e26e8a Compare May 20, 2025 18:02
@codetheweb codetheweb changed the base branch from feat-return-collection-with-version-file-lineage-file-root-collection-2 to graphite-base/4432 May 20, 2025 18:42
@codetheweb codetheweb force-pushed the graphite-base/4432 branch from 5f7fa4a to 71c953d Compare May 20, 2025 18:42
@codetheweb codetheweb force-pushed the feat-sysdb-batch-get-version-file-paths-method branch from 2e26e8a to 7344e5c Compare May 20, 2025 18:42
@graphite-app graphite-app bot changed the base branch from graphite-base/4432 to main May 20, 2025 18:42
@codetheweb codetheweb force-pushed the feat-sysdb-batch-get-version-file-paths-method branch from 7344e5c to c3a7502 Compare May 20, 2025 18:42
@codetheweb codetheweb force-pushed the feat-sysdb-batch-get-version-file-paths-method branch from c3a7502 to 2425e04 Compare May 20, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants