[ENH]: allow deleting v0 from version file & correctly propagate errors on DeleteCollectionVersion

[codetheweb]

Description of changes

Prior to this change, v0 could not be deleted from a version file. This also correctly propagates errors for the DeleteCollectionVersion method.

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

n/a

[codetheweb]

• [ENH]: wire GC v2 to new cleanup modes & call FinishDatabaseDeletion from garbage collector #4671
• [ENH]: soft delete databases, add FinishDatabaseDeletion gRPC method to hard delete databases #4627
• [ENH]: perform collection hard deletes from garbage collector #4605
• [ENH]: sysdb changes to support moving collection hard deletes to garbage collector #4607
• [ENH]: add validation during garbage collection for empty file paths #4586
• [ENH]: garbage collector v2 orchestrator (supports forking) #4468
• [ENH]: allow deleting v0 from version file & correctly propagate errors on DeleteCollectionVersion #4579 👈 (View in Graphite)
• [ENH]: add operator for garbage collection to list all files used by collection version #4466
• [ENH]: add operator to compute versions to garbage collect from version graph #4464
• [ENH]: add orchestrator to construct version graph for garbage collection #4463
• [ENH]: add batch get version file paths method to Sysdb #4432 : 1 other dependent PR (#4447 )
• [ENH]: SysDb should return lineage, version file paths and root collection ID on collections #4557
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codetheweb]

prior to this, v0 in the version file always had created_at_secs: 0

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[propel-code-bot]

Enable Deletion of v0 from Version File & Improve Error Propagation in DeleteCollectionVersion

This PR updates logic so that version 0 (v0) can be deleted from the version file where previously it could not, and ensures errors arising during DeleteCollectionVersion are correctly propagated to the caller. It also includes some adjustments to method signatures and tests to reflect the improved error handling, and minor adjustments in related Rust and Go code to support the new behavior.

Key Changes:
• Allows deletion of v0 (version 0) from the collection version file in sysdb (Go).
• Correctly propagates errors in DeleteCollectionVersion, returning the first encountered error to the caller.
• Refactors test assertions to expect errors where appropriate.
• Improves proto-to-model conversion by ensuring timestamps are set.
• Adds explicit UnknownError in Rust side for SysDB deletion failures and checks individual version deletion results.

Affected Areas:
• go/pkg/sysdb/coordinator/table_catalog.go
• go/pkg/sysdb/coordinator/table_catalog_test.go
• go/pkg/sysdb/grpc/proto_model_convert.go
• rust/garbage_collector/src/operators/delete_versions_at_sysdb.rs
• rust/sysdb/src/sysdb.rs

This summary was automatically generated by @propel-code-bot

[propel-code-bot]

[BestPractice]

The code is returning a successful response (assert.NoError(t, err)) even when the collection does not exist, but that seems to conflict with the implementation which now returns the first error encountered. The test should expect an error in this case.

[codetheweb]

Merge activity

• May 23, 5:10 PM UTC: @codetheweb merged this pull request with Graphite.