[ENH]: add validation during garbage collection for empty file paths

[codetheweb]

Description of changes

Adds a defensive check that validates that the current version is v0 if there are no file paths.

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Added a test.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

n/a

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[codetheweb]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• [ENH]: add validation during garbage collection for empty file paths #4586 👈 (View in Graphite)
• [ENH]: garbage collector v2 orchestrator (supports forking) #4468
• [ENH]: allow deleting v0 from version file & correctly propagate errors on DeleteCollectionVersion #4579
• [ENH]: add operator for garbage collection to list all files used by collection version #4466
• [ENH]: add operator to compute versions to garbage collect from version graph #4464
• [ENH]: add orchestrator to construct version graph for garbage collection #4463
• [ENH]: add batch get version file paths method to Sysdb #4432 : 1 other dependent PR (#4447 )
• [ENH]: SysDb should return lineage, version file paths and root collection ID on collections #4557
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[propel-code-bot]

Add Defensive Validation for Empty File Paths in Garbage Collection

This PR introduces a defensive check in the garbage collector orchestrator to validate that if no file paths are present during garbage collection, the current version and all of its ancestors must be version 0. The update adds a fail-fast invariant in code execution and includes a new test to confirm this behavior. It also includes refactoring of test mock infrastructure in TestSysDb to improve replica handling for version file paths.

Key Changes:
• Added a validation check in GarbageCollectorOrchestratorV2 that verifies empty file paths are only allowed when the version is 0 and all ancestors are also at v0.
• Stored the version graph in orchestrator state for this validation.
• Introduced a detailed error if this invariant is violated.
• Added a corresponding test to ensure the invariant triggers errors appropriately.
• Refactored the test sysdb infrastructure to standardize storage of version file paths on the Collection struct and to update collection version file paths wherever previously a side-table was used.

Affected Areas:
• rust/garbage_collector/src/garbage_collector_orchestrator_v2.rs
• rust/sysdb/src/test_sysdb.rs

This summary was automatically generated by @propel-code-bot