[ENH]: add validation during garbage collection for empty file paths

[codetheweb]

Description of changes

Adds a defensive check that validates that the current version is v0 if there are no file paths.

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Added a test.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

n/a

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[codetheweb]

• [ENH]: wire GC v2 to new cleanup modes & call FinishDatabaseDeletion from garbage collector #4671
• [ENH]: soft delete databases, add FinishDatabaseDeletion gRPC method to hard delete databases #4627
• [ENH]: perform collection hard deletes from garbage collector #4605
• [ENH]: sysdb changes to support moving collection hard deletes to garbage collector #4607
• [ENH]: add validation during garbage collection for empty file paths #4586 👈 (View in Graphite)
• [ENH]: garbage collector v2 orchestrator (supports forking) #4468
• [ENH]: allow deleting v0 from version file & correctly propagate errors on DeleteCollectionVersion #4579
• [ENH]: add operator for garbage collection to list all files used by collection version #4466
• [ENH]: add operator to compute versions to garbage collect from version graph #4464
• [ENH]: add orchestrator to construct version graph for garbage collection #4463
• [ENH]: add batch get version file paths method to Sysdb #4432 : 1 other dependent PR (#4447 )
• [ENH]: SysDb should return lineage, version file paths and root collection ID on collections #4557
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[propel-code-bot]

Add Defensive Validation for Empty File Paths During Garbage Collection

This PR introduces a safeguard in the garbage collector, ensuring that if a collection version has no file paths, it is only permitted if the version is 0 and all its ancestors are also at version 0. It enforces this invariant with explicit validation in the orchestrator, adds a comprehensive test, and cleans up internal sysdb structures to align version file path management with implementation requirements.

Key Changes:
• Added validation logic in garbage_collector_orchestrator_v2.rs to ensure empty file paths are only allowed for v0 and v0 ancestor versions.
• Introduced a new test (errors_on_empty_file_paths) to verify that an error is thrown if a non-v0 version lacks file paths.
• Refactored sysdb test helpers: removed collection_to_version_file_name in favor of using the version_file_path field within collection structs.
• Enhanced test setup for construct_version_graph_orchestrator to ensure collections are properly created before attaching version files.
• Updated proptest_helpers reference to ensure generated transitions for IncrementCollectionVersion only allow new versions with at least one file path.
• Minor test logic fixes in worker orchestration tests to handle updated behavior for version_file_path increments.

Affected Areas:
• Garbage collector orchestrator (validation logic)
• TestSysDb mock and associated test helpers
• Construct version graph orchestrator test setup
• Proptest reference model for garbage collection
• Worker orchestration compaction tests

This summary was automatically generated by @propel-code-bot

[codetheweb]

Merge activity

• May 27, 11:03 PM UTC: @codetheweb merged this pull request with Graphite.