fix(cloudflare): discover prewarm paths from staged worker - #3090
Open
james-elicx wants to merge 10 commits into
Open
fix(cloudflare): discover prewarm paths from staged worker#3090james-elicx wants to merge 10 commits into
james-elicx wants to merge 10 commits into
Conversation
commit: |
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Contributor
|
james-elicx
force-pushed
the
codex/staged-worker-prewarm-discovery
branch
from
August 26, 2026 10:15
f6e7195 to
fd75993
Compare
james-elicx
marked this pull request as ready for review
August 26, 2026 14:31
james-elicx
force-pushed
the
codex/staged-worker-prewarm-discovery
branch
from
August 26, 2026 14:45
fd75993 to
7eb2ad8
Compare
james-elicx
force-pushed
the
codex/staged-worker-prewarm-discovery
branch
from
August 26, 2026 19:42
646504e to
c465bf8
Compare
james-elicx
changed the base branch from
main
to
codex/fix-prerender-stale-time-race
August 26, 2026 19:43
This was referenced Aug 26, 2026
james-elicx
force-pushed
the
codex/staged-worker-prewarm-discovery
branch
from
August 26, 2026 23:25
d1ec11f to
b3b23e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capability stack 2/9. Exact head:
b3b23e7092858d70ae7b8ae3646e063da3c49029. Base: #3108.Full chain: #3108 → #3090 → #3091 → #3092 → #3103 → #3093 → #3094 → #3098 → #3113.
Summary
generateStaticParamsandgetStaticPathscan use real Cloudflare bindingsThis layer moves route discovery into the staged Worker. It does not classify App Pages, emit a cacheability manifest, alter ordinary CDN admission, perform the second upload, or certify cache fills.
Review guide
packages/cloudflare/src/deploy.tsowns upload → 0% stage → triggers → discovery → readiness → warm → promotion.packages/vinext/src/build/prerender-paths.tsperforms bounded remote discovery.packages/vinext/src/server/worker-prerender-discovery.tsauthenticates internal discovery.generateStaticParams, proving binding-backed discovery.Review size
Layer-only diff against this PR's base: 27 files, +1,183/-152.
Validation
vp test run tests/prerender-paths.test.ts— 53/53 on the prior cumulative Pages headvp checkandgit diff --check