fix(cache): gate CDN admission on probed routes - #3092
Open
james-elicx wants to merge 20 commits into
Open
Conversation
commit: |
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
james-elicx
force-pushed
the
codex/cacheability-manifest-admission
branch
from
August 26, 2026 10:51
266ed64 to
17fd250
Compare
Contributor
|
james-elicx
force-pushed
the
codex/cacheability-manifest-admission
branch
from
August 26, 2026 14:45
17fd250 to
bf4c4aa
Compare
james-elicx
force-pushed
the
codex/cacheability-manifest-admission
branch
from
August 26, 2026 17:09
bf4c4aa to
c4470f4
Compare
james-elicx
force-pushed
the
codex/cacheability-manifest-admission
branch
from
August 26, 2026 17:47
c4470f4 to
c308688
Compare
james-elicx
force-pushed
the
codex/cacheability-manifest-admission
branch
from
August 26, 2026 18:29
c308688 to
a968165
Compare
james-elicx
force-pushed
the
codex/cacheability-manifest-admission
branch
from
August 26, 2026 19:33
a968165 to
9b5d065
Compare
james-elicx
force-pushed
the
codex/cacheability-manifest-admission
branch
2 times, most recently
from
August 26, 2026 21:10
0b0624c to
7866c95
Compare
james-elicx
force-pushed
the
codex/cacheability-manifest-admission
branch
from
August 26, 2026 21:27
7866c95 to
3c43c25
Compare
james-elicx
marked this pull request as ready for review
August 26, 2026 22:08
This was referenced Aug 26, 2026
james-elicx
force-pushed
the
codex/cacheability-manifest-admission
branch
from
August 26, 2026 23:25
c771cb2 to
a430639
Compare
Member
Author
|
/bigbonk review for issues. Hard time limit: 20 minutes; return all findings or a partial review by then. |
Contributor
|
@james-elicx Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
james-elicx
force-pushed
the
codex/cacheability-manifest-admission
branch
from
August 27, 2026 00:43
54285ff to
549601d
Compare
james-elicx
force-pushed
the
codex/cacheability-manifest-admission
branch
from
August 27, 2026 00:58
549601d to
92aa5ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capability stack 4/9. Exact head:
f50e5a1d7526ec067df7306085c5f05d253e457d. Base: #3091.Full chain: #3108 → #3090 → #3091 → #3092 → #3103 → #3093 → #3094 → #3098 → #3113.
Summary
Fail-closed behavior
no-storehas/missingconditions are evaluated by pathname eligibility, not only by the probe request's current headersno-storemay be replaced after proof, while application/config/private policy remains an absolute vetoThe manifest is a Worker module asset containing classification only—never response bodies. Origin-managed/KV adapters retain their existing streaming path.
Next.js reference
Next.js drains cacheable App Route Handler responses before resolving static generation (
packages/next/src/server/route-modules/app-route/module.ts). The built-workerd regression here covers late stream request reads and late stream failure at that same completion boundary.Review guide
cacheability-manifest.tsvalidates the embedded artifact.cacheability-request.tsowns exact matching, capture limits, and admission.app-route-handler-execution.tscompletes potentially cacheable Route Handler bodies before public admission.app-router-entry.tsgates obvious non-page requests before loading admission code.cdn-adapter.runtime.tsfails closed while classification is pending.This PR does not alter cache keys, response
Vary, Worker entrypoints, or request routing. Existing framework and adapterVaryreplacement semantics are unchanged.Review size
Layer-only diff against this PR's base: 47 files, +2,723/-76.
Validation
vp checkandgit diff --check