fix(cache): preserve prerender metadata across completion races - #3108
Open
james-elicx wants to merge 2 commits into
Open
fix(cache): preserve prerender metadata across completion races#3108james-elicx wants to merge 2 commits into
james-elicx wants to merge 2 commits into
Conversation
commit: |
james-elicx
force-pushed
the
codex/fix-prerender-stale-time-race
branch
from
August 26, 2026 19:42
d0c7267 to
9cc60c2
Compare
Contributor
|
james-elicx
changed the base branch from
main
to
codex/fix-node-24-stream-test-drain
August 26, 2026 19:42
james-elicx
changed the base branch from
codex/fix-node-24-stream-test-drain
to
main
August 26, 2026 19:45
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
james-elicx
marked this pull request as ready for review
August 26, 2026 21:28
This was referenced Aug 26, 2026
james-elicx
force-pushed
the
codex/fix-prerender-stale-time-race
branch
from
August 26, 2026 23:25
9cc60c2 to
1fd53d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capability stack 1/9. Exact head:
1fd53d7b899a4e34cb0dbf49b99168936a942b6a. Base:main.Full chain: #3108 → #3090 → #3091 → #3092 → #3103 → #3093 → #3094 → #3098 → #3113.
Summary
This keeps two independent completion-ordering fixes outside the cacheability implementation layers:
flush()Without the stale-time fix, prerendered HTML can omit
staleTimeSecondseven though the prerender manifest records the correct value.No staged probing, cacheability manifest, CDN-admission behavior, or warming behavior is introduced here. #3090 begins the capability itself.
Review size
Layer-only diff against this PR's base: 3 files, +83/-8.
Validation
vp checkandgit diff --check