Removed -Wconversion warnings in part of framework #47339

Dr15Jones · 2025-02-12T21:47:46Z

PR description:

Primarily did lowest level packages such as most DataFormats maintained by Core and FWCore/Utilities.

PR validation:

Code compiles. Doing USER_CXXFLAGS=-Wconversion scram b showed the changes avoid the warnings.

cmsbuild · 2025-02-12T21:48:17Z

cms-bot internal usage

cmsbuild · 2025-02-12T21:52:00Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47339/43672

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/Common/test/TestWriteTriggerResults.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Framework/interface/ESProducer.h modified in PR(s): Print ES module dependences from Tracer #46929
- File FWCore/Framework/src/EDConsumerBase.cc modified in PR(s): Print ES module dependences from Tracer #46929
- File FWCore/Framework/test/stubs/ToyIntProducers.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/ParameterSet/src/types.cc modified in PR(s): Introduce vFloat and float types in ParameterSets #45216

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47339/43672/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47339/43672/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

Primarily did lowest level packages such as most DataFormats maintained by Core and FWCore/Utilities.

Dr15Jones · 2025-02-12T21:54:56Z

please test

cmsbuild · 2025-02-12T22:00:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47339/43673

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/Common/test/TestWriteTriggerResults.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Framework/interface/ESProducer.h modified in PR(s): Print ES module dependences from Tracer #46929
- File FWCore/Framework/src/EDConsumerBase.cc modified in PR(s): Print ES module dependences from Tracer #46929
- File FWCore/Framework/test/stubs/ToyIntProducers.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/ParameterSet/src/types.cc modified in PR(s): Introduce vFloat and float types in ParameterSets #45216

cmsbuild · 2025-02-12T22:01:11Z

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

DataFormats/Common (core)
DataFormats/Provenance (core)
FWCore/Common (core)
FWCore/Concurrency (core)
FWCore/FWLite (core)
FWCore/Framework (core)
FWCore/Integration (core)
FWCore/MessageLogger (core)
FWCore/MessageService (core)
FWCore/ParameterSet (core)
FWCore/PrescaleService (core)
FWCore/PythonParameterSet (core)
FWCore/Reflection (core)
FWCore/SOA (core)
FWCore/Services (core)
FWCore/SharedMemory (core)
FWCore/Sources (core)
FWCore/TestProcessor (core)
FWCore/Utilities (core)
IOMC/RandomEngine (core)
IOPool/Input (core)
IOPool/Streamer (core)
IOPool/TFileAdaptor (core)
SimDataFormats/RandomEngine (simulation)
Utilities/General (core)

@Dr15Jones, @civanch, @kpedro88, @makortel, @mdhildreth, @smuzaffar can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @denizsun, @fabiocos, @felicepantaleo, @fwyzard, @makortel, @martinamalberti, @missirol, @mmusich, @rovere, @salimcerci, @wddgit, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

fwyzard · 2025-02-12T22:16:06Z

DataFormats/Common/interface/DataFrameContainer.h

@@ -126,17 +126,18 @@ namespace edm {

    const_IterPair pair(size_t i) const { return const_IterPair(m_ids.begin() + i, m_data.begin() + i * m_stride); }

-    DataFrame operator[](size_t i) { return DataFrame(*this, i); }
+    DataFrame operator[](size_t i) { return DataFrame(*this, static_cast<DataFrame::size_type>(i)); }


In these cases, wouldn't it be better to change the function parameter type to match what is expected ?
That is,

Suggested change

DataFrame operator[](size_t i) { return DataFrame(*this, static_cast<DataFrame::size_type>(i)); }

DataFrame operator[](DataFrame::size_type i) { return DataFrame(*this, i); }

?

fwyzard · 2025-02-12T22:35:28Z

DataFormats/Common/interface/HLTGlobalStatus.h


    /// Get number of paths stored
-    unsigned int size() const { return paths_.size(); }
+    auto size() const { return paths_.size(); }


Suggested change

auto size() const { return paths_.size(); }

size_type size() const { return paths_.size(); }

?

fwyzard · 2025-02-12T22:35:58Z

DataFormats/Common/interface/HLTGlobalStatus.h

+      const auto n(size());
+      for (decltype(size()) i = 0; i != n; ++i)


Suggested change

const auto n(size());

for (decltype(size()) i = 0; i != n; ++i)

const size_type n = size();

for (size_type i = 0; i != n; ++i)

?

makortel · 2025-02-12T22:29:29Z

DataFormats/Common/interface/DetSetVectorNew.h

        m_item.offset = offset;

-        m_v.m_dataSize = m_v.m_data.size();
+        m_v.m_dataSize = static_cast<unsigned int>(m_v.m_data.size());


Suggested change

m_v.m_dataSize = static_cast<unsigned int>(m_v.m_data.size());

m_v.m_dataSize = static_cast<size_type>(m_v.m_data.size());

?

makortel · 2025-02-12T22:29:41Z

DataFormats/Common/interface/DetSetVectorNew.h

@@ -451,7 +451,7 @@ namespace edmNew {
    void resize(size_t isize, size_t dsize) {
      m_ids.resize(isize);
      m_data.resize(dsize);
-      m_dataSize = m_data.size();
+      m_dataSize = static_cast<unsigned int>(m_data.size());


Suggested change

m_dataSize = static_cast<unsigned int>(m_data.size());

m_dataSize = static_cast<size_type>(m_data.size());

?

makortel · 2025-02-12T22:30:04Z

DataFormats/Common/interface/DetSetVectorNew.h

@@ -463,14 +463,14 @@ namespace edmNew {
      Item& item = addItem(iid, isize);
      m_data.resize(m_data.size() + isize);
      std::copy(idata, idata + isize, m_data.begin() + item.offset);
-      m_dataSize = m_data.size();
+      m_dataSize = static_cast<unsigned int>(m_data.size());


Suggested change

m_dataSize = static_cast<unsigned int>(m_data.size());

m_dataSize = static_cast<size_type>(m_data.size());

?

makortel · 2025-02-12T22:30:14Z

DataFormats/Common/interface/DetSetVectorNew.h

      return DetSet(*this, item, false);
    }
    //make space for it
    DetSet insert(id_type iid, size_type isize) {
      Item& item = addItem(iid, isize);
      m_data.resize(m_data.size() + isize);
-      m_dataSize = m_data.size();
+      m_dataSize = static_cast<unsigned int>(m_data.size());


Suggested change

m_dataSize = static_cast<unsigned int>(m_data.size());

m_dataSize = static_cast<size_type>(m_data.size());

?

makortel · 2025-02-12T22:33:12Z

DataFormats/Common/interface/MapOfVectors.h

@@ -88,10 +88,10 @@ namespace edm {
      m_keys.push_back(k);
      m_data.resize(m_offsets.back() + v.size());
      std::copy(v.begin(), v.end(), m_data.begin() + m_offsets.back());
-      m_offsets.push_back(m_data.size());
+      m_offsets.push_back(static_cast<unsigned int>(m_data.size()));


Suggested change

m_offsets.push_back(static_cast<unsigned int>(m_data.size()));

m_offsets.push_back(static_cast<size_type>(m_data.size()));

?

makortel · 2025-02-12T22:51:32Z

FWCore/Utilities/interface/EDPutToken.h

@@ -103,7 +103,7 @@ namespace edm {
    static constexpr unsigned int s_uninitializedValue = 0xFFFFFFFF;

    constexpr explicit EDPutTokenT(unsigned int iValue) noexcept : m_value(iValue) {}
-    constexpr explicit EDPutTokenT(unsigned long int iValue) noexcept : m_value(iValue) {}
+    constexpr explicit EDPutTokenT(unsigned long int iValue) noexcept : m_value(static_cast<unsigned int>(iValue)) {}


Why do we need the unsigned long int overload?

makortel · 2025-02-12T22:52:58Z

FWCore/Utilities/interface/isFinite.h

@@ -32,7 +32,7 @@ namespace edm {

  template <>
  constexpr bool isFinite(long double x) {
-    double xx = x;
+    double xx = static_cast<double>(x);
    return isFinite(xx);


I wonder if this long double overload really works properly (in presence of fast math), but ok, whatever the behavior is, it is there already.

makortel · 2025-02-12T22:54:03Z

FWCore/Utilities/src/CPUTimer.cc

@@ -113,10 +113,12 @@ CPUTimer::Times CPUTimer::calculateDeltaTime() const {
  struct timespec tp;

  clock_gettime(CLOCK_PROCESS_CPUTIME_ID, &tp);
-  returnValue.cpu_ = tp.tv_sec - startCPUTime_.tv_sec + nanosecToSec * (tp.tv_nsec - startCPUTime_.tv_nsec);
+  returnValue.cpu_ =
+      double(tp.tv_sec - startCPUTime_.tv_sec) + nanosecToSec * double(tp.tv_nsec - startCPUTime_.tv_nsec);


Could static_cast be used here?

makortel · 2025-02-12T22:54:20Z

FWCore/Utilities/src/ChildrenCPUTimer.cc

-  returnValue = theUsage.ru_stime.tv_sec + theUsage.ru_utime.tv_sec - startCPUTime_.tv_sec +
-                microsecToSec * (theUsage.ru_stime.tv_usec + theUsage.ru_utime.tv_usec - startCPUTime_.tv_usec);
+  returnValue = double(theUsage.ru_stime.tv_sec + theUsage.ru_utime.tv_sec - startCPUTime_.tv_sec) +
+                microsecToSec * double(theUsage.ru_stime.tv_usec + theUsage.ru_utime.tv_usec - startCPUTime_.tv_usec);


Could astatic_cast be used here?

makortel · 2025-02-12T22:58:16Z

FWCore/Utilities/test/cputimer_t.cppunit.cpp

@@ -89,7 +89,7 @@ void testCPUTimer::testTiming()
    getrusage(RUSAGE_SELF, &theUsage2);
    nowTime.tv_sec = theUsage2.ru_utime.tv_sec;
    nowTime.tv_usec = theUsage2.ru_utime.tv_usec;
-  } while (nowTime.tv_sec - startTime.tv_sec + 1E-6 * (nowTime.tv_usec - startTime.tv_usec) < 1);
+  } while (double(nowTime.tv_sec - startTime.tv_sec) + 1E-6 * double(nowTime.tv_usec - startTime.tv_usec) < 1);


static_cast?

cmsbuild · 2025-02-13T00:16:41Z

-1

Failed Tests: Build
Size: This PR adds an extra 796KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49d04e/44365/summary.html
COMMIT: bcf2c09
CMSSW: CMSSW_15_1_X_2025-02-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47339/44365/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin src/PerfTools/AllocMonitor/plugins/moduleAlloc_setupFile.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_15_1_X_2025-02-12-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_1_X_2025-02-12-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_1_X_2025-02-12-1100/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/boost/1.80.0-96a02191111b66819e07de179cb25a0e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/lcg/root/6.32.09-0a945d6e24dcaabe218b38fa8292785d/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/tbb/v2021.9.0-9b0f135342cfe979b6500c59f501774e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/PerfTools/AllocMonitor/plugins/PerfToolsAllocMonitorAuto/moduleAlloc_setupFile.cc.d src/PerfTools/AllocMonitor/plugins/moduleAlloc_setupFile.cc -o tmp/el8_amd64_gcc12/src/PerfTools/AllocMonitor/plugins/PerfToolsAllocMonitorAuto/moduleAlloc_setupFile.cc.o
>> Compiling edm plugin src/PerfTools/AllocMonitor/plugins/monitor_file_utilities.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_15_1_X_2025-02-12-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_1_X_2025-02-12-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_1_X_2025-02-12-1100/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/boost/1.80.0-96a02191111b66819e07de179cb25a0e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/lcg/root/6.32.09-0a945d6e24dcaabe218b38fa8292785d/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/tbb/v2021.9.0-9b0f135342cfe979b6500c59f501774e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02876/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/PerfTools/AllocMonitor/plugins/PerfToolsAllocMonitorAuto/monitor_file_utilities.cc.d src/PerfTools/AllocMonitor/plugins/monitor_file_utilities.cc -o tmp/el8_amd64_gcc12/src/PerfTools/AllocMonitor/plugins/PerfToolsAllocMonitorAuto/monitor_file_utilities.cc.o
src/PerfTools/AllocMonitor/plugins/monitor_file_utilities.cc: In function 'void edm::moduleAlloc::monitor_file_utilities::moduleIdToLabel(std::ostream&, const std::vector >&, char, const std::string&, const std::string&)':
src/PerfTools/AllocMonitor/plugins/monitor_file_utilities.cc:17:35: error: narrowing conversion of '(std::size_t)width' from 'std::size_t' {aka 'long unsigned int'} to 'int' [-Werror=narrowing]
   17 |     OStreamColumn col0{iIDHeader, width};
      |                                   ^~~~~
cc1plus: some warnings being treated as errors
gmake: *** [tmp/el8_amd64_gcc12/src/PerfTools/AllocMonitor/plugins/PerfToolsAllocMonitorAuto/monitor_file_utilities.cc.o] Error 1
>> Building edm plugin tmp/el8_amd64_gcc12/src/PerfTools/AllocMonitor/plugins/PerfToolsAllocMonitorAuto/libPerfToolsAllocMonitorAuto.so

cmsbuild added this to the CMSSW_15_1_X milestone Feb 12, 2025

cmsbuild added simulation-pending core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 12, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 12, 2025

Removed -Wconversion warnings in part of framework

bcf2c09

Primarily did lowest level packages such as most DataFormats maintained by Core and FWCore/Utilities.

Dr15Jones force-pushed the conversionFramework branch from 434e5a0 to bcf2c09 Compare February 12, 2025 21:54

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 12, 2025

cmsbuild added tests-started and removed tests-pending labels Feb 12, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 12, 2025

fwyzard reviewed Feb 12, 2025

View reviewed changes

makortel reviewed Feb 12, 2025

View reviewed changes

cmsbuild added tests-rejected and removed tests-started labels Feb 13, 2025

makortel mentioned this pull request Feb 14, 2025

Removed -Wconversion warnings in part of framework cms-sw/framework-team#1247

Closed

This was referenced Feb 26, 2025

Move CPUServiceBase, RootHandlers, and TimingServiceBase to FWCore/AbstractServices #47466

Merged

Access PathsAndConsumesOfModules from new signal #47467

Merged

This was referenced Mar 7, 2025

Compartmentalize how ProductRegistry is filled #47533

Merged

Add Process name, reduced configuration ID, and ParameterSet ID to the JobReport #47548

Merged

Create new main ProductRegistry if input products change #47584

Merged

This was referenced Mar 20, 2025

Can mark Parameters as obsolete in fillDescriptions #47642

Merged

Remove SubProcess and references in EventProcessor related code #47659

Merged

This was referenced Mar 27, 2025

Move RandomNumberGenerator service base class to FWCore/AbstractServices #47719

Merged

A More Flexible And Lightweight CA #47611

Open

Dr15Jones closed this Apr 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed -Wconversion warnings in part of framework #47339

Removed -Wconversion warnings in part of framework #47339

Dr15Jones commented Feb 12, 2025

cmsbuild commented Feb 12, 2025 •

edited

Loading

cmsbuild commented Feb 12, 2025

Dr15Jones commented Feb 12, 2025

cmsbuild commented Feb 12, 2025

cmsbuild commented Feb 12, 2025

fwyzard Feb 12, 2025

fwyzard Feb 12, 2025

fwyzard Feb 12, 2025

makortel Feb 12, 2025

makortel Feb 12, 2025

makortel Feb 12, 2025

makortel Feb 12, 2025

makortel Feb 12, 2025

makortel Feb 12, 2025

makortel Feb 12, 2025

makortel Feb 12, 2025

makortel Feb 12, 2025

makortel Feb 12, 2025

cmsbuild commented Feb 13, 2025

	DataFrame operator[](size_t i) { return DataFrame(*this, static_cast<DataFrame::size_type>(i)); }
	DataFrame operator[](DataFrame::size_type i) { return DataFrame(*this, i); }

	auto size() const { return paths_.size(); }
	size_type size() const { return paths_.size(); }

		const auto n(size());
		for (decltype(size()) i = 0; i != n; ++i)

	m_v.m_dataSize = static_cast<unsigned int>(m_v.m_data.size());
	m_v.m_dataSize = static_cast<size_type>(m_v.m_data.size());

	m_dataSize = static_cast<unsigned int>(m_data.size());
	m_dataSize = static_cast<size_type>(m_data.size());

	m_offsets.push_back(static_cast<unsigned int>(m_data.size()));
	m_offsets.push_back(static_cast<size_type>(m_data.size()));

Removed -Wconversion warnings in part of framework #47339

Removed -Wconversion warnings in part of framework #47339

Conversation

Dr15Jones commented Feb 12, 2025

PR description:

PR validation:

cmsbuild commented Feb 12, 2025 • edited Loading

cmsbuild commented Feb 12, 2025

Dr15Jones commented Feb 12, 2025

cmsbuild commented Feb 12, 2025

cmsbuild commented Feb 12, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Feb 13, 2025

Build

cmsbuild commented Feb 12, 2025 •

edited

Loading