Compartmentalize how ProductRegistry is filled #47533

Dr15Jones · 2025-03-07T19:34:59Z

PR description:

constrain where in the code the ProductRegistry has additional non-dropped entries added
isolate when in the construction sequence a signal is sent when the ProductRegistry is changed

PR validation:

This is a code refactoring and as such no changes in behavior are expected. Code compiles and all but one framework unit test pass.

The only known failure is TestIOPoolInputNoParentDictionary. When that test run it copies parts of code from CMSSW to a new build area. The problem is it doesn't copy enough code to work with this change (code in DataFormats/Common/test fails to build).

resolves cms-sw/framework-team#1296

To set the helper, a temporary is created and filled and then moved to the ProductRegistry.

This isolates where where the ProductRegistry can have additional products added.

cmsbuild · 2025-03-07T19:35:22Z

cms-bot internal usage

cmsbuild · 2025-03-07T19:36:49Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47533/43991

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/Provenance/interface/ProductRegistry.h modified in PR(s): Disable ROOT automatic class parsing during finishSchedule() #46858
- File DataFormats/Provenance/src/ProductRegistry.cc modified in PR(s): Disable ROOT automatic class parsing during finishSchedule() #46858
- File FWCore/Framework/interface/GlobalSchedule.h modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467
- File FWCore/Framework/interface/ProductRegistryHelper.h modified in PR(s): Removed -Wconversion warnings in part of framework #47339
- File FWCore/Framework/interface/Schedule.h modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467
- File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467
- File FWCore/Framework/src/GlobalSchedule.cc modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467
- File FWCore/Framework/src/ProductRegistryHelper.cc modified in PR(s): Disable ROOT automatic class parsing in ProductRegistryHelper::addToRegistry #47397
- File FWCore/Framework/src/Schedule.cc modified in PR(s): Disable ROOT automatic class parsing during finishSchedule() #46858, Access PathsAndConsumesOfModules from new signal #47467
- File FWCore/Framework/src/SubProcess.cc modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467
- File FWCore/Framework/test/productregistry.cppunit.cc modified in PR(s): Disable ROOT automatic class parsing during finishSchedule() #46858
- File FWCore/TestProcessor/interface/TestProcessor.h modified in PR(s): Removed -Wconversion warnings in part of framework #47339
- File FWCore/TestProcessor/src/TestProcessor.cc modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47533/43991/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47533/43991/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

Dr15Jones · 2025-03-07T19:40:35Z

please test

cmsbuild · 2025-03-07T19:42:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47533/43992

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/Provenance/interface/ProductRegistry.h modified in PR(s): Disable ROOT automatic class parsing during finishSchedule() #46858
- File DataFormats/Provenance/src/ProductRegistry.cc modified in PR(s): Disable ROOT automatic class parsing during finishSchedule() #46858
- File FWCore/Framework/interface/GlobalSchedule.h modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467
- File FWCore/Framework/interface/ProductRegistryHelper.h modified in PR(s): Removed -Wconversion warnings in part of framework #47339
- File FWCore/Framework/interface/Schedule.h modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467
- File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467
- File FWCore/Framework/src/GlobalSchedule.cc modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467
- File FWCore/Framework/src/ProductRegistryHelper.cc modified in PR(s): Disable ROOT automatic class parsing in ProductRegistryHelper::addToRegistry #47397
- File FWCore/Framework/src/Schedule.cc modified in PR(s): Disable ROOT automatic class parsing during finishSchedule() #46858, Access PathsAndConsumesOfModules from new signal #47467
- File FWCore/Framework/src/SubProcess.cc modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467
- File FWCore/Framework/test/productregistry.cppunit.cc modified in PR(s): Disable ROOT automatic class parsing during finishSchedule() #46858
- File FWCore/TestProcessor/interface/TestProcessor.h modified in PR(s): Removed -Wconversion warnings in part of framework #47339
- File FWCore/TestProcessor/src/TestProcessor.cc modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467

cmsbuild · 2025-03-07T19:43:16Z

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

DataFormats/Provenance (core)
FWCore/Framework (core)
FWCore/Sources (core)
FWCore/TestProcessor (core)
IOPool/SecondaryInput (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @mmusich, @rovere, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2025-03-07T21:17:38Z

-1

Failed Tests: Build HeaderConsistency ClangBuild
Size: This PR adds an extra 480KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b09ca/44853/summary.html
COMMIT: 9eaf910
CMSSW: CMSSW_15_1_X_2025-03-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47533/44853/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_15_1_X_2025-03-07-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_1_X_2025-03-07-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_X_2025-03-07-1100/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-94d5b66203ab8a015ad76ed29be3e51e/include/LCG -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/boost/1.80.0-7642db88b69862429c1c9c9980662789/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/curl/7.79.0-d8c0d5017cfad573d276c56bd08114b8/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/lcg/root/6.32.11-575650675fc09042e42e48da8061099a/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/tbb/v2022.0.0-10fdc07bd3d228f4c274203a8cd20b5c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/Mixing/Base/src/MixingBase/SecondaryEventProvider.cc.d src/Mixing/Base/src/SecondaryEventProvider.cc -o tmp/el8_amd64_gcc12/src/Mixing/Base/src/MixingBase/SecondaryEventProvider.cc.o
>> Compiling  src/Mixing/Base/src/PileupRandomNumberGenerator.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_15_1_X_2025-03-07-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_1_X_2025-03-07-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_X_2025-03-07-1100/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-94d5b66203ab8a015ad76ed29be3e51e/include/LCG -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/boost/1.80.0-7642db88b69862429c1c9c9980662789/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/curl/7.79.0-d8c0d5017cfad573d276c56bd08114b8/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/lcg/root/6.32.11-575650675fc09042e42e48da8061099a/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/tbb/v2022.0.0-10fdc07bd3d228f4c274203a8cd20b5c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02879/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/Mixing/Base/src/MixingBase/PileupRandomNumberGenerator.cc.d src/Mixing/Base/src/PileupRandomNumberGenerator.cc -o tmp/el8_amd64_gcc12/src/Mixing/Base/src/MixingBase/PileupRandomNumberGenerator.cc.o
In file included from src/Mixing/Base/interface/PileUp.h:14,
                 from src/Mixing/Base/src/PileUp.cc:1:
poison/FWCore/Framework/interface/SignallingProductRegistry.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
      |  ^~~~~
In file included from src/Mixing/Base/src/PileUp.cc:8:
poison/FWCore/Framework/interface/SignallingProductRegistry.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

cmsbuild · 2025-03-10T18:41:16Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b09ca/44890/summary.html
COMMIT: e2915ba
CMSSW: CMSSW_15_1_X_2025-03-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47533/44890/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3920300
DQMHistoTests: Total failures: 48
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3920232
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 214 log files, 184 edm output root files, 49 DQM output files
TriggerResults: no differences found

Dr15Jones · 2025-03-10T18:43:51Z

ignore tests-rejected with manual-override

civanch · 2025-03-11T09:46:17Z

+1

Dr15Jones · 2025-03-11T13:10:17Z

ping @cms-sw/dqm-l2 ping

makortel · 2025-03-11T13:32:01Z

Comparison differences are related to #47071

antoniovagnerini · 2025-03-11T16:09:45Z

+dqm

cmsbuild · 2025-03-11T16:10:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Dr15Jones · 2025-03-12T14:00:24Z

@cms-sw/orp-l2 please merge as this is needed for work I'm presently doing.

antoniovilela · 2025-03-12T15:35:12Z

+1

Dr15Jones added 3 commits March 6, 2025 11:13

Hold ProductResolverIndexHelper via const

e7f919b

To set the helper, a temporary is created and filled and then moved to the ProductRegistry.

Only SignallingProductRegistry can add products

e3e58f9

This isolates where where the ProductRegistry can have additional products added.

Must explicitly ask for the ProductRegistry in SignallingProductRegistry

692153c

cmsbuild added this to the CMSSW_15_1_X milestone Mar 7, 2025

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 7, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 7, 2025

Dr15Jones force-pushed the limitAddingToProductRegistry branch from a1bfffa to 9eaf910 Compare March 7, 2025 19:40

cmsbuild added tests-started code-checks-pending and removed tests-pending code-checks-rejected labels Mar 7, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 7, 2025

cmsbuild added tests-rejected and removed tests-started labels Mar 7, 2025

Dr15Jones force-pushed the limitAddingToProductRegistry branch from 9eaf910 to 22cdb24 Compare March 7, 2025 22:04

cmsbuild added simulation-pending and removed tests-rejected code-checks-approved labels Mar 7, 2025

cmsbuild added the core-approved label Mar 10, 2025

This was referenced Mar 10, 2025

Remove FinalPath from the framework #47546

Merged

Add Process name, reduced configuration ID, and ParameterSet ID to the JobReport #47548

Merged

cmsbuild added tests-rejected and removed tests-started labels Mar 10, 2025

cmsbuild added tests-approved tests-manual-override and removed tests-rejected labels Mar 10, 2025

cmsbuild added simulation-approved and removed simulation-pending labels Mar 11, 2025

cmsbuild mentioned this pull request Mar 11, 2025

Remove excessive includes in DataFormats/Provenance #47561

Merged

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Mar 11, 2025

cmsbuild mentioned this pull request Mar 11, 2025

Remove configuration support for SubProcess and its tests #47565

Merged

cmsbuild added orp-approved and removed orp-pending labels Mar 12, 2025

cmsbuild merged commit a69a71c into cms-sw:master Mar 12, 2025
10 of 11 checks passed

Dr15Jones deleted the limitAddingToProductRegistry branch March 12, 2025 16:31

cmsbuild mentioned this pull request Mar 13, 2025

Create new main ProductRegistry if input products change #47584

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compartmentalize how ProductRegistry is filled #47533

Compartmentalize how ProductRegistry is filled #47533

Dr15Jones commented Mar 7, 2025 •

edited

Loading

cmsbuild commented Mar 7, 2025 •

edited

Loading

cmsbuild commented Mar 7, 2025

Dr15Jones commented Mar 7, 2025

cmsbuild commented Mar 7, 2025

cmsbuild commented Mar 7, 2025

cmsbuild commented Mar 7, 2025

cmsbuild commented Mar 10, 2025

Dr15Jones commented Mar 10, 2025

civanch commented Mar 11, 2025

Dr15Jones commented Mar 11, 2025

makortel commented Mar 11, 2025

antoniovagnerini commented Mar 11, 2025

cmsbuild commented Mar 11, 2025

Dr15Jones commented Mar 12, 2025

antoniovilela commented Mar 12, 2025

Compartmentalize how ProductRegistry is filled #47533

Compartmentalize how ProductRegistry is filled #47533

Conversation

Dr15Jones commented Mar 7, 2025 • edited Loading

PR description:

PR validation:

cmsbuild commented Mar 7, 2025 • edited Loading

cmsbuild commented Mar 7, 2025

Dr15Jones commented Mar 7, 2025

cmsbuild commented Mar 7, 2025

cmsbuild commented Mar 7, 2025

cmsbuild commented Mar 7, 2025

Build

Clang Build

cmsbuild commented Mar 10, 2025

Unit Tests

Comparison Summary

Dr15Jones commented Mar 10, 2025

civanch commented Mar 11, 2025

Dr15Jones commented Mar 11, 2025

makortel commented Mar 11, 2025

antoniovagnerini commented Mar 11, 2025

cmsbuild commented Mar 11, 2025

Dr15Jones commented Mar 12, 2025

antoniovilela commented Mar 12, 2025

Dr15Jones commented Mar 7, 2025 •

edited

Loading

cmsbuild commented Mar 7, 2025 •

edited

Loading