Have fillDescriptions generate a template for VPSet in cfi files

[Dr15Jones]

PR description:

The ParameterSetDescription passed to the function which adds a VPSet to the configuration is used to generate the template argument for the cms.VPSet written to the cfi files. This allows python to validate PSets passed to the VPSet.

This also fixes a bug where declaring cms.VPSet(cms.PSet(), template = ...) and then calling dumpPython() on the VPSet would generate syntactically invalid python.

PR validation:

Code compiles and framework unit tests pass.

resolves cms-sw/framework-team#1226

[Dr15Jones]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47374/43732

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/ParameterSet/python/Config.py modified in PR(s): faster edmConfigDump with --prune, also prunes unreferenced PSets #43276, Introduce vFloat and float types in ParameterSets #45216
  • File FWCore/ParameterSet/python/Types.py modified in PR(s): Introduce vFloat and float types in ParameterSets #45216
  • File FWCore/ParameterSet/src/ParameterDescription.cc modified in PR(s): Introduce vFloat and float types in ParameterSets #45216
  • File FWCore/ParameterSet/test/test_catch_ParameterSetDescription.cc modified in PR(s): Introduce vFloat and float types in ParameterSets #45216

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• FWCore/Integration (core)
• FWCore/ParameterSet (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 116KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3834d2/44438/summary.html
COMMIT: f4700bc
CMSSW: CMSSW_15_1_X_2025-02-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47374/44438/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3905432
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3905409
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[mmusich]

It appears this PR created issues for ConfDB, see discussion at #47630 (comment)

[makortel]

For the future record, in the end this PR did not create problems. More details in #47653.