Skip to content

Include CICADA v2.2.0 configuration as modification to 2025 L1T Era #47423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

aloeliger
Copy link
Contributor

PR description:

This PR updates the CICADA L1T Emulator to the proposed model version v2.2.0 for 2025 running. This PR is dependent on cms-sw/cmsdist#9709

PR validation:

The python pathing has been tested to work. The CICADA model has been tested locally to run and provide model accurate CICADA scores.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, but will need to be ported to the eventual data-taking release, whether if that is different from the current cycle.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 21, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47423/43818

@cmsbuild
Copy link
Contributor

Pull request #47423 was updated.

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#9709

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f2104/44606/summary.html
COMMIT: 220d659
CMSSW: CMSSW_15_1_X_2025-02-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47423/44606/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f2104/44606/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f2104/44606/git-merge-result

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 61
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920219
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 47 workflows

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f2104/44716/summary.html
COMMIT: 220d659
CMSSW: CMSSW_15_1_X_2025-02-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47423/44716/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 58
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920222
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 47 workflows

@aloeliger
Copy link
Contributor Author

The changes in triggers here are lost CICADA triggers in 2025. Since this is a change of the 2025 model to a generally lower score output model, this is entirely expected

@aloeliger
Copy link
Contributor Author

+l1

@cmsbuild
Copy link
Contributor

@aloeliger if this PR is ready to be reviewed by the release team, please remove the "Draft" status.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aloeliger for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • L1Trigger/L1TCaloLayer1 (l1)

can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild cmsbuild merged commit 4af0123 into cms-sw:master Mar 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants