Skip to content

Add era modifiers for ScoutingNano to account for changes in 2022-24 and beginning of 2025 #47302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

patinkaew
Copy link
Contributor

@patinkaew patinkaew commented Feb 8, 2025

PR description:

This enables ScoutingNano workflows in CMSSW_15_0_X+ to run on scouting samples (ScoutingPFRun3, ScoutingPFMonitor) collected in 2022-2024. Addressed changes are as follows:

2022:

  • Add EDFilter to skip events without scouting object products in ScoutingPFMonitor

2023:

  • Add additional track variables to the Run 3 scouting electron collection for low pT electrons (cms-sw/cmssw#41025)
  • Add EDFilter to skip events without scouting object products in ScoutingPFMonitor

2024:

  • Add off-diagonal entries of the vertex fit covariance matrix (cms-sw/cmssw#43758)
  • Electron and Photon Scouting Data Format Update for 2024 pp Collisions (cms-sw/cmssw#43744)
  • Add EDFilter to skip events without scouting object products in ScoutingPFMonitor

2025:

  • Remove EDFilter to skip events without scouting object products in ScoutingPFMonitor since all ScoutingPFMonitor events should now have scouting object products (CMSHLT-3089)

In summary, this PR

  • adds era modifiers for 2023,2024,2025: run3_scouting_nanoAOD_2023, run3_scouting_nanoAOD_2024, and run3_scouting_nanoAOD_2025 which are added to Run3_2023, Run3_2024, and Run3_2025.
  • removes era modifer run3_scouting_nanoAOD_post2023 as run3_scouting_nanoAOD_2024 and run3_scouting_nanoAOD_2025 are introduced instead.
  • adds EDFilter to skip events without scouting object products in ScoutingPFMonitor. This can also be configured in cmsDriver.py by adding --customise PhysicsTools/NanoAOD/custom_run3scouting_cff.skipEventsWithoutScouting
  • adds @ScoutMonitor flavour to automatically turn on/off the EDFilter based on era modifiers (turn on for 2022-24 and turn off for 2025). This should be used when running with ScoutingPFMonitor/RAW in scouting-only configuration.
  • adds the above feature to automatically turn on/off the EDFilter based on era modifiers to @ScoutFromMini. When running on data, this assumes running on ScoutingPFMonitor/MINIAOD and will turn on the EDFilter for 2022-24 and turn off on 2025. When running on MC, EDFilter will be turn off.

Note on different flavours:

  • Data. The default Scout is designed to be used with ScoutingPFRun3 (containing scouting only). ScoutMonitor should be used with ScoutingPFMonitor/RAW and ScoutFromMini should be used with ScoutingPFMonitor/MiniAOD. The default Scout will not check for events without scouting products while ScoutMonitor and ScoutFromMini will check and skip events without scouting products with 2022-24 samples but turn off this check for 2025. For L1 bits and objects, Scout assume hltFEDSelectorL1 of type FEDRawDataCollection exists, ScoutMonitor assume rawDataCollector of type FEDRawDataCollection exists, and ScoutFromMini assume gtStage2Digis, gmtStage2Digis, caloStage2Digis exists in the input files. In all flavours, reduced variables for L1 objects are used.
  • MC. The default Scout and ScoutFromMini can be used and they differ in how L1 bits and objects are handled. For Scout, L1 bits and objects are produced from gtStage2DigisScouting (similar to gtStage2Digis) with hltFEDSelectorL1 of type FEDRawDataCollection as input. ForScoutFromMini, L1bits are obtained from standard L1TriggerResultsConverter (similar to standard NanoAOD) and L1 objects are obtained from gmtStage2Digis (L1 Muon) and caloStage2Digis (L1 EG, Jet, EtSum, Tau). In all flavours, reduced variables for L1 objects are used. Both Scout and ScoutFromMini will not check for events without scouting products. ScoutMonitor should not be used.

Proposal for this change was presented [1].

PR validation:

Pass all tests from scram b runtests use-ibeos.
Pass all ScoutingNano-related relval_nano workflows from runTheMatrix.py --ibeos -l 2500.131,2500.227,2500.228,2500.237,2500.238

In addition, several cmsDriver.py commands have been tested on data and MC samples documented in [2].
In brief, concerning data:

  • @Scout works for ScoutingPFRun3 2022-24
  • @ScoutMonitor works for ScoutingPFMonitor 2022-24
  • @ScoutFromMini works for ScoutingPFMonitor 2024 (Scouting objects are in MiniAOD starting in Prompt 2024)
  • @Prompt+@ScoutMonitor works for ScoutingPFMonitor 2023. Input 2022 fails because of Tau.
  • @Prompt+@ScoutFromMini works for ScoutingPFMonitor 2024 (Scouting objects are in MiniAOD starting in Prompt 2024)
    Please see commands in [2]. Relevant test results (python config, root, event content, size report, log) are included in [3]. Summary of size report is in [4].

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport, but backport to 15_0_0 will likely follow.

[1] https://indico.cern.ch/event/1492373/#11-offline-scoutingnano-develo
[2] https://codimd.web.cern.ch/s/Fgye0cLYG
[3] https://cernbox.cern.ch/s/5P2nt1ChLhcwhFU
[4] 2025-02-08_ScoutingNano_Size-Report-Summary

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2025

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47302/43622

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47302/43623

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2025

Pull request #47302 was updated.

@patinkaew
Copy link
Contributor Author

I closed this PR. This is now partially (EDFilter part) superseded by cms-sw/cmssw#47739. I will update here again when another part (Era modifier) is superseded in another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants