Skip to content

Conversation

@lorisleiva
Copy link
Member

@lorisleiva lorisleiva commented Oct 30, 2024

This PR removes the inner NodeStack inside the LinkableDictionary and requests stacks when resolving linkables in order to find the right program/instruction to fetch from.

This PR also tags places that need to be fixed and tested before the end of this refactoring stack.

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 5042447

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@codama/visitors-core Minor
@codama/renderers-core Patch
@codama/renderers-js-umi Patch
@codama/renderers-js Patch
@codama/renderers-rust Patch
@codama/validators Minor
@codama/visitors Minor
@codama/renderers Patch
codama Minor
@codama/nodes-from-anchor Patch
@codama/errors Minor
@codama/node-types Minor
@codama/nodes Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lorisleiva lorisleiva force-pushed the loris/remove-stack-from-linkable-dictionary branch from 658cdcf to 5042447 Compare November 4, 2024 11:11
@lorisleiva lorisleiva mentioned this pull request Nov 4, 2024
@lorisleiva lorisleiva marked this pull request as ready for review November 4, 2024 12:18
Copy link
Member Author

lorisleiva commented Nov 4, 2024

Merge activity

  • Nov 4, 8:46 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 4, 8:46 AM EST: A user merged this pull request with Graphite.

@lorisleiva lorisleiva merged commit 4799a7f into main Nov 4, 2024
4 checks passed
@lorisleiva lorisleiva deleted the loris/remove-stack-from-linkable-dictionary branch November 4, 2024 13:46
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants