Skip to content

Conversation

@lorisleiva
Copy link
Member

@lorisleiva lorisleiva commented Nov 4, 2024

This PR fixes an issue in the unwrapDefinedTypesVisitor where complex link node paths would be incorrectly resolved due to the fact that the NodeStack would follow in invalid path in the tree. The new methods to save and restore NodePaths inside the NodeStack help us fix this.

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2024

🦋 Changeset detected

Latest commit: adfdd8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@codama/visitors Minor
codama Minor
@codama/nodes-from-anchor Patch
@codama/renderers-js Patch
@codama/renderers Patch
@codama/errors Minor
@codama/node-types Minor
@codama/nodes Minor
@codama/validators Minor
@codama/visitors-core Minor
@codama/renderers-core Patch
@codama/renderers-js-umi Patch
@codama/renderers-rust Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

lorisleiva commented Nov 4, 2024

Merge activity

  • Nov 4, 8:46 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 4, 9:12 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 4, 9:13 AM EST: A user merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from loris/fix-link-node-path-for-byte-size-visitor to graphite-base/283 November 4, 2024 14:08
@lorisleiva lorisleiva changed the base branch from graphite-base/283 to main November 4, 2024 14:10
@lorisleiva lorisleiva force-pushed the loris/fix-link-node-path-for-unwrap-type-visitor branch from 20cceb8 to adfdd8c Compare November 4, 2024 14:11
@lorisleiva lorisleiva merged commit 5bdd745 into main Nov 4, 2024
2 checks passed
@lorisleiva lorisleiva deleted the loris/fix-link-node-path-for-unwrap-type-visitor branch November 4, 2024 14:13
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants