Skip to content

Conversation

@lorisleiva
Copy link
Member

@lorisleiva lorisleiva commented Nov 1, 2024

This PR adds new NodePath helper functions and pushes some of the responsibilities from the NodeStack to the NodePath. The former is designed to be a mutable stack that updates as we traverse the tree, whereas the latter is designed to hold an immutable path of nodes finishing in a specific typed node.

@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2024

⚠️ No Changeset found

Latest commit: 07df737

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author

lorisleiva commented Nov 4, 2024

Merge activity

  • Nov 4, 8:46 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 4, 9:00 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 4, 9:01 AM EST: A user merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from loris/use-node-path-in-renderers-js to graphite-base/275 November 4, 2024 13:53
@lorisleiva lorisleiva changed the base branch from graphite-base/275 to main November 4, 2024 13:56
@lorisleiva lorisleiva force-pushed the loris/refactor-node-path-and-node-stack branch from 4cc0374 to 07df737 Compare November 4, 2024 13:59
@lorisleiva lorisleiva merged commit 35dec6a into main Nov 4, 2024
2 checks passed
@lorisleiva lorisleiva deleted the loris/refactor-node-path-and-node-stack branch November 4, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants