Draft
Conversation
Changes:
Total lines: 4456 (-11) |
deployed preview: https://517.connect-d5y.pages.devWelcome to connect! Make sure to:
Mobile
Desktop
|
This was referenced Apr 8, 2025
greatgitsby
force-pushed
the
feat/unified-title-bar
branch
from
4fe458b to
c396421
Compare
greatgitsby
force-pushed
the
feat/unified-title-bar
branch
3 times, most recently
from
b16abd1 to
2c6640b
Compare
greatgitsby
commented
Apr 8, 2025
Contributor
Author
|
in future PR, i will fix the alignment of the devices with the header, example:
|
Contributor
Author
|
tests are failing after 1m, don't think it would be related to these changes i think we need to revisit the waitFor timeout in tests |
Contributor
Author
|
i also think the |
greatgitsby
force-pushed
the
feat/unified-title-bar
branch
from
db04519 to
092cec9
Compare
This reverts commit f595483.
greatgitsby
force-pushed
the
feat/unified-title-bar
branch
from
38480dc to
c447feb
Compare
Collaborator
|
I don't think I like the nested title bars 😕
|
Contributor
Author
|
it’s the same as old connect
would centering the date str make it feel more like old connect, less compact? |
Contributor
Author
let's address this in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves: commaai/connect#462, commaai/connect#501
more or less copied old connect style. not including dropdown yet as we don't have that abstraction (will be a follow up).
header.mov