WIP: Car Port: Subaru Ascent 2023#1234
Conversation
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
|
Moved to draft since #1193 supercedes this. |
|
Had a successful drive today, though the steering inputs were a bit jerky. I'm going to wait to add my openpilot route until the Panda PR gets approved (pending feedback of course), and I take the time to tune the experience to be a little smoother. |
|
Please share the route if you can, I think it will make reviewing and verifying things easier |
|
Uploading a route with Openpilot running presently (see above). I didn't do anything special, but it's running and doing lateral fairly well. |
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
09a837a to
1b87bff
Compare
Mentioned in @martinl PR, and it seems these are no longer queries/returned in my vehicle
Shamelessley copied from jnewb1 to support my 2023 Ascent
scope errors, non-existent variables, other silly things
1b87bff to
f0fbafc
Compare
Haven't tested anything yet - likely further changes required
|
Rebased to bring in Safety's move to this repo #2217 |
2023 Subaru Ascent
selfdrive/opcar/docs.pyto generate new docsPanda PR (tests won't pass without this): commaai/panda#2020