Skip to content

WIP: Car Port: Subaru Ascent 2023#1234

Closed
bravochar wants to merge 15 commits intocommaai:masterfrom
bravochar:ascent-2023
Closed

WIP: Car Port: Subaru Ascent 2023#1234
bravochar wants to merge 15 commits intocommaai:masterfrom
bravochar:ascent-2023

Conversation

@bravochar
Copy link
Copy Markdown
Contributor

@bravochar bravochar commented Sep 11, 2024

2023 Subaru Ascent

  • added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/opcar/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot: '3d0a2ec61b4035d3|00000012--f60c832c46'
  • route with stock system: "99437cef6d5ff2ee|2023-03-13--21-21-38" (It was like that when I got here)
  • car harness used (if comma doesn't sell it, put N/A): Subaru D

Panda PR (tests won't pass without this): commaai/panda#2020

@github-actions github-actions bot added car related to opendbc/car/ subaru fingerprint labels Sep 11, 2024
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

@bravochar bravochar marked this pull request as draft September 11, 2024 13:56
@bravochar
Copy link
Copy Markdown
Contributor Author

Moved to draft since #1193 supercedes this.

@bravochar bravochar changed the title Fingerprint: Subaru Ascent 2023 WIP: Car Port: Subaru Ascent 2023 Sep 14, 2024
@bravochar
Copy link
Copy Markdown
Contributor Author

Had a successful drive today, though the steering inputs were a bit jerky. I'm going to wait to add my openpilot route until the Panda PR gets approved (pending feedback of course), and I take the time to tune the experience to be a little smoother.

@martinl
Copy link
Copy Markdown
Contributor

martinl commented Sep 14, 2024

Please share the route if you can, I think it will make reviewing and verifying things easier

@bravochar
Copy link
Copy Markdown
Contributor Author

Uploading a route with Openpilot running presently (see above). I didn't do anything special, but it's running and doing lateral fairly well.

@github-actions
Copy link
Copy Markdown
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Nov 15, 2024
@github-actions github-actions bot added DBC signals can related to CAN tools, aka opendbc/can/ toyota volkswagen labels Nov 23, 2024
@sshane sshane mentioned this pull request Feb 4, 2025
@fredyshox fredyshox mentioned this pull request Feb 23, 2025
12 tasks
Haven't tested anything yet - likely further changes required
@github-actions github-actions bot removed DBC signals can related to CAN tools, aka opendbc/can/ toyota volkswagen fingerprint labels May 1, 2025
@bravochar bravochar closed this May 10, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Car Ports May 10, 2025
@bravochar
Copy link
Copy Markdown
Contributor Author

Rebased to bring in Safety's move to this repo #2217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car related to opendbc/car/ stale subaru

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants