test(run): synchronize PTY observation fixtures - #482
Merged
schickling merged 1 commit intoSep 6, 2026
Merged
Conversation
agent-identity: mbp2025.direct.omp.5tek2r48 agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.11 agent-runtime: OMP 18.0.11 tooling-profile: dotfiles@4cc7b25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The downstream dotfiles package carried this patch because several PTY observation tests raced the fake child scripts on Darwin. The tests now use an explicit ready/release barrier instead of assuming process scheduling order.
Verification
st2::runtests pass on aarch64-darwin innix developnix build .#st2 --no-link -Lin dotfiles passed with this patch and ran the full st2 library suite (691 tests)git diff --checkThe repository-wide
cargo fmt --all --checkis red on unchanged files under the current flake toolchain, so this PR does not reformat unrelated code.Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimetooling_profile