fix: reconstruction with pycolmap mapper option input level error#493
Open
monty3396 wants to merge 1 commit intocvg:masterfrom
Open
fix: reconstruction with pycolmap mapper option input level error#493monty3396 wants to merge 1 commit intocvg:masterfrom
monty3396 wants to merge 1 commit intocvg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when exec reconstruction scripts with --mapper_option (example: filter_min_tri_angle=1.5)
because pycolmap.incremental_mapping function options' type is pycolmap._core.IncrementalPipelineOption. IncrementalPipelineOptions type includes top level (include mapper)and sub level (mapper's config parameter). The original code placed them on the same level(top level). so an error occurred。
changed success