Skip to content

fix: reconstruction with pycolmap mapper option input level error #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
monty3396 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: reconstruction with pycolmap mapper option input level error #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion hloc/reconstruction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,21 @@ def restart_progress_bar():
)
pbars[-1].update(2)

pipeline_options = pycolmap.IncrementalPipelineOptions()
if options and isinstance(options, dict):
for k, v in options.items():
# Check if this parameter belongs to mapper
if hasattr(pipeline_options.mapper, k):
setattr(pipeline_options.mapper, k, v)
# Or belongs to top level (such as num_threads)
elif hasattr(pipeline_options, k):
setattr(pipeline_options, k, v)

reconstructions = pycolmap.incremental_mapping(
database_path,
image_dir,
sfm_path,
options=options or {},
options=pipeline_options,
initial_image_pair_callback=restart_progress_bar,
next_image_callback=lambda: pbars[-1].update(1),
)
Expand Down