Partial fixes and clarifications for issues raised in #30#31
Draft
Zador-Pataki wants to merge 1 commit intomainfrom
Draft
Partial fixes and clarifications for issues raised in #30#31Zador-Pataki wants to merge 1 commit intomainfrom
Zador-Pataki wants to merge 1 commit intomainfrom
Conversation
|
@Zador-Pataki Great work on the initial fixes for issue #30! I've tested your What I Added (Building on Your Work):Completed your Path conversion pattern: # Your original lines 26-27 in simple.py:
cache_dir = Path(cache_dir) if cache_dir is not None else None
images_dir = Path(images_dir) if images_dir is not None else None
# I extended with the same pattern for remaining parameters:
intrinsics_pth = Path(intrinsics_pth) if intrinsics_pth is not None else None
refrec_dir = Path(refrec_dir) if refrec_dir is not None else NoneAdditional bug fixes:
My Fork with Changes:
The changes strictly follow your coding style and complete the Path conversion I also completed the code for ply, gltf, colmap output (dense points with camera location and textures). They are easier to peek and inspect compared to html. I would like to merge them as well to be able to showcase your work better. Let' me know how you would like to coordinate the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses parts of #30. Specifically:
SimpleTestSome changes are provisional — feedback welcome before finalizing.