Skip to content

Partial fixes and clarifications for issues raised in #30#31

Draft
Zador-Pataki wants to merge 1 commit intomainfrom
zador/fixes
Draft

Partial fixes and clarifications for issues raised in #30#31
Zador-Pataki wants to merge 1 commit intomainfrom
zador/fixes

Conversation

@Zador-Pataki
Copy link
Collaborator

This PR addresses parts of #30. Specifically:

  • Fixes broken instructions in the README and example scripts (pending feedback)
  • Notes the need for p7zip-full when extracting ETH3D .7z archives (pending feedback)
  • Fixes a minor bug in SimpleTest

Some changes are provisional — feedback welcome before finalizing.

@Zador-Pataki Zador-Pataki requested a review from Copilot July 9, 2025 13:13

This comment was marked as spam.

@PoyrazTahan
Copy link

PoyrazTahan commented Aug 10, 2025

@Zador-Pataki Great work on the initial fixes for issue #30! I've tested your
changes and extended them with some additional improvements that follow your exact
approach.

What I Added (Building on Your Work):

Completed your Path conversion pattern:

# Your original lines 26-27 in simple.py:
cache_dir = Path(cache_dir) if cache_dir is not None else None
images_dir = Path(images_dir) if images_dir is not None else None

# I extended with the same pattern for remaining parameters:
intrinsics_pth = Path(intrinsics_pth) if intrinsics_pth is not None else None
refrec_dir = Path(refrec_dir) if refrec_dir is not None else None

Additional bug fixes:

  • Fixed variable typo imanme → imname in SimpleParser
  • Improved intrinsics loading logic to handle both provided and default paths
  • Added multi-reconstruction script for easier testing

My Fork with Changes:

The changes strictly follow your coding style and complete the Path conversion
approach you started. This should resolve more of the issues mentioned in #30.


I also completed the code for ply, gltf, colmap output (dense points with camera location and textures). They are easier to peek and inspect compared to html. I would like to merge them as well to be able to showcase your work better. Let' me know how you would like to coordinate the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants